From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbdBJJSj (ORCPT ); Fri, 10 Feb 2017 04:18:39 -0500 Received: from seldsegrel01.sonyericsson.com ([37.139.156.29]:1439 "EHLO SELDSEGREL01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbdBJJSg (ORCPT ); Fri, 10 Feb 2017 04:18:36 -0500 Subject: Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller To: Michal Hocko , Greg Kroah-Hartman References: <9febd4f7-a0a7-5f52-e67b-df3163814ac5@sonymobile.com> <20170209192640.GC31906@dhcp22.suse.cz> <20170209200737.GB11098@kroah.com> <20170209205407.GF31906@dhcp22.suse.cz> <845d420f-dd26-fb48-c8ef-10ca1995daf8@sonymobile.com> <20170210075149.GA17166@kroah.com> <20170210075949.GB10893@dhcp22.suse.cz> CC: , Riley Andrews , , , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Linus Torvalds From: peter enderborg Message-ID: Date: Fri, 10 Feb 2017 10:05:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170210075949.GB10893@dhcp22.suse.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2017 08:59 AM, Michal Hocko wrote: > On Fri 10-02-17 08:51:49, Greg KH wrote: >> On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote: > [...] >>> Until then we have to polish this version as good as we can. It is >>> essential for android as it is now. >> But if no one is willing to do the work to fix the reported issues, why >> should it remain? Can you do the work here? You're already working on >> fixing some of the issues in a differnt way, why not do the "real work" >> here instead for everyone to benifit from? > Well, to be honest, I do not think that the current code is easily > fixable. This patch improves the current situation and address some of the issues that makes android devices behaviour different than other linux systems. > The approach was wrong from the day 1. Abusing slab shrinkers > is just a bad place to stick this logic. This all belongs to the > userspace. But now it is there and we have to stick with it. > For that we need a proper mm pressure notification which is > supposed to be vmpressure but that one also doesn't seem to work all > that great. So rather than trying to fix unfixable I would stronly > suggest focusing on making vmpressure work reliably.