From: David Laight <David.Laight@ACULAB.COM>
To: 'Christoph Probst' <kernel@probst.it>, Steve French <smfrench@gmail.com>
Cc: Pavel Shilovsky <pavel.shilovsky@gmail.com>,
Jeremy Allison <jra@samba.org>, Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] cifs: fix strcat buffer overflow in smb21_set_oplock_level()
Date: Tue, 7 May 2019 11:02:17 +0000 [thread overview]
Message-ID: <e83726b3537a46fa84249c4caabbe839@AcuMS.aculab.com> (raw)
In-Reply-To: <20190507061028.GP28577@netzpunkt.org>
From: Christoph Probst
> Sent: 07 May 2019 07:10
> Steve French schrieb am 06.05.2019 um 23:18 Uhr:
>
> > On Mon, May 6, 2019 at 2:03 PM Pavel Shilovsky
> > <pavel.shilovsky@gmail.com> wrote:
> > >
> > > The patch itself is fine but I think we have a bigger problem here:
> >
> > Good point. Perhaps make update to the same patch to include both changes
>
> I'll update my patch to implement the change suggested by Pavel.
>
> I'll also switch the strcat to strncat and use strncpy in the "None"-case.
strncat() is never the function you are looking for.
The 'n' is the maximum number of bytes to copy, not the length
of the target buffer.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2019-05-07 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 15:16 Christoph Probst
2019-05-06 16:53 ` Steve French
2019-05-06 16:56 ` Jeremy Allison
2019-05-06 17:02 ` Steve French
2019-05-06 19:03 ` Pavel Shilovsky
2019-05-06 21:18 ` Steve French
2019-05-07 6:10 ` Christoph Probst
2019-05-07 11:02 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e83726b3537a46fa84249c4caabbe839@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=jra@samba.org \
--cc=kernel@probst.it \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel.shilovsky@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®