From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8798337692 for ; Thu, 27 Nov 2025 16:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259728; cv=none; b=dS5usTYI1SlDnjvOQ7UvHRc04W3QDIYWnQuJmFxR8Z6kMaYq+pfmtxe6VODpMG2NzCis6Mpsql2X++brMuZcUu/d/2Nazph6yU7LULYkM0fcn9J2Ut0t5ZHTMEY7V8kUDsldyhOdS+RJUxD71Q6TsJkkYwu/Lyq+Xtiw6dprqW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259728; c=relaxed/simple; bh=ta5nvtkAvSEQ0YgT7d6P/ibBZiqxnWaoK6Psv3QiXqs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gMcLSu10b7ulrVQ0zN0GgsAwJXCvXjM9fjGVa/WwjhmRrqeCyboBqdJyFBQFxn+SV9juOLQINH376dg2bWO8uslpYVgLpkgj65ytOJurwOs94THMJOSM4cnWWSvZOJYqrfLezZ4nMYQv9Ocd1GXc4i74Gxa7GKkinGIIHdMCLiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KNdwRw+L; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KNdwRw+L" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-bc09b3d3afeso598138a12.0 for ; Thu, 27 Nov 2025 08:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764259723; x=1764864523; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=R8go5ngYUd73cjKuDGIyMFUa6ctvuEnzg99jFKgPO6g=; b=KNdwRw+LMlyITikDE03NnFBTKHvy+xLI3xhIaAY4EhkZ+fZKQYcZYMDZGv2ZgXqcyK RG1LCX3fKrSU7OXfEKIdMUpdH7BD+m+lfinMODZV1emmVxskBJuP5+5G03+IGxD1RVAe jp5cnHjktpDCCqluaTvnvJDJbHuOOkN7/WaDLpSczfmDuEFG7nW+/gQyfrWNXMTQ6Q5S UUWHMC0OvmSVglvrl4oskkARsBvugl3IWt+A/9YiAL4pBnYGtmQsy5jh03fHPSUiEdTx FQ0K+EX2X3GMFYe/N+nvARoomXOItfsEiLdOvyzv/YnquuEORCRmvJSMeHTk/ErFvCMH Pm3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764259723; x=1764864523; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R8go5ngYUd73cjKuDGIyMFUa6ctvuEnzg99jFKgPO6g=; b=Ax+YOZUIy9lNAVhieUNcTET2ssrrzIOKrLomybBwWXlqjBQJ9a2q0UIIeV74G4R0Lw CONt/otDBMioLjKd74x4W/917HBxTMSWHQsyPlfAixY++lsRfJryVmDM4bpiaoxLhG0G +GlSTeCj5cpUfvAIeD3ACrgI5Vf03TkzBh44gsQfDuKdN+ShEQvw4dR/QU4/IOtMptTv SKV5gpSPaZKpoDKnZJYgMSpRc5h45ply9Gu1zshUgOBJFdj/Co2q91jIKXJp5/qQZUWb vVHmo3WFiN283ZwSbd2EJHqI+9rQAR1yuWftdkX3y13BerquqGRcf0hzp001uO+I8urk gH9w== X-Forwarded-Encrypted: i=1; AJvYcCUcd6VPKM6F1fwtCHhT4vd3CcbBvK6XShQLegK/eYlb2MExdvH2L8NK9tCEF0TT91x9lpDtY94KLhOxKpE=@vger.kernel.org X-Gm-Message-State: AOJu0YyYo1rH9U23PpWeYdIwyTz5ZoAzmpBdVEPxNtvgAQHweUu7iuiO 6/FkyV4Y2KO0DnJyDfsIyApct0psy4M/jYY7r0sdOEKwskHZa2l6b1UL X-Gm-Gg: ASbGncsmz2Fx8muRs/Cl7yjvMF/TT02vz9F0lsRO3M8Nfp6TRZNR2nltlFPf5x7nVGC 88BtK4N+MNXS9APapi9GVeWs1TLv3M8/tGPEK5rSRXFYzhFRHHbubLsB/+UGU302b1bXN+aPRJv PEJJopF7DpJF41maN2Tjk4McPfznwLSgDf57hwr6ArVuZH4FTxLluFhGD5r1uGydhyBb6Sv74ys aE3Q7pNBVNJzOuNH4u/I7xdaenEQrUtJVOzUVAmkG7J6u719qau2XH8dW/L2N2Fn2hi0reUj9MT hdPi/Eyr8w2cNT5OSY4QFAW/F/aocvqe08R1fGv+Q1Qri4roggcoNu4RK4KmS1gkY5hs7tXINK+ yGFsFcPSWNvA3BfoclxH33B53s3k4YjcPGA/YB+yu8f2CDd4sXXnKev3YLx/exQs/lc7aK58/OV Urm1F+fC48fcuCePfZMYMXIfs= X-Google-Smtp-Source: AGHT+IGNzEBkzLWPObgUvVK78LZO7aewF+H131l8nSXj2T2UBjAmy+ewdhC6bKVn3L6oihLw1wQohg== X-Received: by 2002:a05:7301:dd98:b0:2a6:9ea0:6db with SMTP id 5a478bee46e88-2a719fb9759mr10317934eec.28.1764259722530; Thu, 27 Nov 2025 08:08:42 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a965b47caasm7617756eec.6.2025.11.27.08.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 08:08:42 -0800 (PST) Sender: Guenter Roeck Date: Thu, 27 Nov 2025 08:08:40 -0800 From: Guenter Roeck To: Johan Hovold Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] hwmon: (max6697) fix regmap leak on probe failure Message-ID: References: <20251127134351.1585-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127134351.1585-1-johan@kernel.org> On Thu, Nov 27, 2025 at 02:43:51PM +0100, Johan Hovold wrote: > The i2c regmap allocated during probe is never freed. > > Switch to using the device managed allocator so that the regmap is > released on probe failures (e.g. probe deferral) and on driver unbind. > > Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap") > Cc: stable@vger.kernel.org # 6.12 > Cc: Guenter Roeck > Signed-off-by: Johan Hovold Applied. Thanks, Guenter