From: Joe Perches <joe@perches.com>
To: Sergey Shtylyov <s.shtylyov@omprussia.ru>,
Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] module: some refactoring in module_sig_check()
Date: Wed, 14 Oct 2020 01:35:19 -0700 [thread overview]
Message-ID: <e8382da95dda4dffa06f81a05e92e5555a074bab.camel@perches.com> (raw)
In-Reply-To: <e6fd4ba1-b431-afd8-1800-3a8f4b74f30e@omprussia.ru>
On Wed, 2020-10-14 at 11:18 +0300, Sergey Shtylyov wrote:
> Hello!
>
> On 14.10.2020 1:44, Joe Perches wrote:
>
> > > Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo.
> > > I'm doing some little refactoring in module_sig_check()...
> > >
> > > [1/2] module: merge repetitive strings in module_sig_check()
> > > [2/2] module: unindent comments in module_sig_check()
> >
> > I think this code is rather cryptic and could be made clearer.
> >
> > How about:
> > ---
> > kernel/module.c | 51 ++++++++++++++++++++++++++-------------------------
> > 1 file changed, 26 insertions(+), 25 deletions(-)
>
> Looks good. Do you want to post complete patch(es)? :-)
I don't like posting actual patches on top of other people.
It's a complete and compilable diff, it's just unsigned.
If you want a Signed-off-by: here's one:
Signed-off-by: Joe Perches <joe@perches.com>
next prev parent reply other threads:[~2020-10-14 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 20:32 Sergey Shtylyov
2020-10-13 20:34 ` [PATCH 1/2] module: merge repetitive strings " Sergey Shtylyov
2020-10-13 20:35 ` [PATCH 2/2] module: unindent comments " Sergey Shtylyov
2020-10-13 22:44 ` [PATCH 0/2] module: some refactoring " Joe Perches
2020-10-14 8:18 ` Sergey Shtylyov
2020-10-14 8:35 ` Joe Perches [this message]
2020-10-14 19:44 ` Sergey Shtylyov
2020-10-14 20:48 ` Joe Perches
2020-10-22 15:09 ` Jessica Yu
2020-10-22 15:29 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8382da95dda4dffa06f81a05e92e5555a074bab.camel@perches.com \
--to=joe@perches.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omprussia.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®