From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Mark Brown <broonie@kernel.org>, valdis.kletnieks@vt.edu
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 11/11] ASoC: wm8994: Mark expected switch fall-through
Date: Mon, 6 Aug 2018 06:48:13 -0500 [thread overview]
Message-ID: <e839abf4-cf54-fe2e-7eb8-57b12106b586@embeddedor.com> (raw)
In-Reply-To: <20180806113426.GA17525@sirena.org.uk>
On 08/06/2018 06:34 AM, Mark Brown wrote:
> On Fri, Aug 03, 2018 at 01:55:18PM -0400, valdis.kletnieks@vt.edu wrote:
>> On Fri, 03 Aug 2018 11:56:12 -0500, "Gustavo A. R. Silva" said:
>>> On 08/03/2018 11:45 AM, Mark Brown wrote:
>>>> Basically nobody ever uses OPCLK so I'd be susprised if anyone ever
>>>> noticed.
>
>> I wonder if nobody uses it because any attempts to do so get an error? :)
>
> No, nobody ever physically wires up an OPCLK. If one was there it'd be
> unavoidable.
>
>>> I see. I wonder what's the best approach in this case. Should that code be
>>> removed instead of 'fixed'?
>
>> I'm thinking that's a spot that needs a 'break;' added.
>
> Yes.
>
OK. I'll send a patch for this. But I wonder what's the best approach in this case,
so the fix can also be applied to stable.
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-08-06 11:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 19:47 [PATCH 00/11] ASoC: codecs: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-01 19:47 ` [PATCH 01/11] ASoC: wm8961: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-01 19:49 ` [PATCH 02/11] ASoC: rt5640: " Gustavo A. R. Silva
2018-08-01 19:50 ` [PATCH 03/11] ASoC: rt5677: " Gustavo A. R. Silva
2018-08-01 19:51 ` [PATCH 04/11] ASoC: wm8955: " Gustavo A. R. Silva
2018-08-01 19:51 ` [PATCH 05/11] ASoC: wm8960: " Gustavo A. R. Silva
2018-08-01 19:52 ` [PATCH 06/11] ASoC: wm8904: " Gustavo A. R. Silva
2018-08-01 19:53 ` [PATCH 07/11] ASoC: wm8996: " Gustavo A. R. Silva
2018-08-01 19:54 ` [PATCH 08/11] ASoC: wm8962: " Gustavo A. R. Silva
2018-08-01 19:54 ` [PATCH 09/11] ASoC: wm8995: " Gustavo A. R. Silva
2018-08-01 19:55 ` [PATCH 10/11] ASoC: wm9081: " Gustavo A. R. Silva
2018-08-01 19:56 ` [PATCH 11/11] ASoC: wm8994: " Gustavo A. R. Silva
2018-08-03 16:26 ` valdis.kletnieks
2018-08-03 16:41 ` Gustavo A. R. Silva
2018-08-03 16:45 ` Mark Brown
2018-08-03 16:56 ` Gustavo A. R. Silva
2018-08-03 17:55 ` valdis.kletnieks
2018-08-03 18:24 ` Gustavo A. R. Silva
2018-08-06 11:34 ` Mark Brown
2018-08-06 11:48 ` Gustavo A. R. Silva [this message]
2018-08-06 11:52 ` Mark Brown
2018-08-06 11:59 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e839abf4-cf54-fe2e-7eb8-57b12106b586@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®