From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Saurabh Singh Sengar <ssengar@linux.microsoft.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
linux-um@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org,
"Gabriel L. Somlo" <gsomlo@gmail.com>
Subject: Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware
Date: Tue, 12 Mar 2024 14:44:19 +0000 [thread overview]
Message-ID: <e83b606a-e34e-423f-b26b-df745052d06b@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdUKa-KdWfYswEpFvj3RjQPM+ThhU85myfBGVkXxZqbHWw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Tue, Mar 12, 2024 at 03:41:32PM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 21, 2024 at 3:06 PM Rob Herring <robh+dt@kernel.org> wrote:
> static int __init regulator_init_complete(void)
> {
> /*
> * Since DT doesn't provide an idiomatic mechanism for
> * enabling full constraints and since it's much more natural
> * with DT to provide them just assume that a DT enabled
> * system has full constraints.
> */
> if (of_have_populated_dt())
> has_full_constraints = true;
>
> ...
> }
> late_initcall_sync(regulator_init_complete);
> (The latter looks a bit futile, as have_full_constraints() already
> contains a check for of_have_populated_dt()?)
Yes, it's duplicated and we should remove it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-12 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 6:08 Saurabh Singh Sengar
2024-02-21 14:06 ` Rob Herring
2024-03-12 14:41 ` Geert Uytterhoeven
2024-03-12 14:44 ` Mark Brown [this message]
2024-03-12 14:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e83b606a-e34e-423f-b26b-df745052d06b@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gsomlo@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=ssengar@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®