mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next v2] wifi: mac80211: consider links for validating SCAN_FLAG_AP in scan request during MLO
Date: Tue, 24 Jun 2025 15:26:57 +0200	[thread overview]
Message-ID: <e83c0841a3875aebcbb830949abc44d909d64da4.camel@sipsolutions.net> (raw)
In-Reply-To: <20250624-fix_scan_ap_flag_requirement_during_mlo-v2-1-c8067d0ee1f0@oss.qualcomm.com>

On Tue, 2025-06-24 at 14:25 +0530, Aditya Kumar Singh wrote:
> Commit 78a7a126dc5b ("wifi: mac80211: validate SCAN_FLAG_AP in scan request
> during MLO") introduced a check that rejects scan requests if any link is
> already beaconing. This works fine when all links share the same radio, but
> breaks down in multi-radio setups.
> 
> Consider a scenario where a 2.4 GHz link is beaconing and a scan is
> requested on a 5 GHz link, each backed by a different physical radio. The
> current logic still blocks the scan, even though it should be allowed. As a
> result, interface bring-up fails unnecessarily in valid configurations.
> 
> Fix this by checking whether the scan is being requested on the same
> underlying radio as the beaconing link. Only reject the scan if it targets
> a link that is already beaconing and the SCAN_FLAG_AP is not set. This
> ensures correct behavior in multi-radio environments and avoids false
> rejections.
> 

This triggers a warning in ieee80211_is_radio_idx_in_scan_req() in hwsim
tests.

johannes

      reply	other threads:[~2025-06-24 13:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24  8:55 Aditya Kumar Singh
2025-06-24 13:26 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e83c0841a3875aebcbb830949abc44d909d64da4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=aditya.kumar.singh@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®