From: Joe Perches <joe@perches.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com
Subject: Re: [PATCH -next] scsi: mpi3mr: Make some symbols static
Date: Thu, 03 Jun 2021 22:22:17 -0700 [thread overview]
Message-ID: <e841993b4b04a5c1dd2e266f1fe22c7debe8a425.camel@perches.com> (raw)
In-Reply-To: <20210604051105.1122667-1-yangyingliang@huawei.com>
On Fri, 2021-06-04 at 13:11 +0800, Yang Yingliang wrote:
> Fix the following warnings:
>
> drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static?
> drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static?
> drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static?
[]
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
[]
> @@ -21,14 +21,14 @@ MODULE_LICENSE(MPI3MR_DRIVER_LICENSE);
> MODULE_VERSION(MPI3MR_DRIVER_VERSION);
>
>
> /* Module parameters*/
> -int prot_mask = -1;
> +static int prot_mask = -1;
> module_param(prot_mask, int, 0);
> MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07");
drivers/scsi/mpi3mr/mpi3mr_fw.c:extern int prot_mask;
drivers/scsi/mpi3mr/mpi3mr_fw.c: if (prot_mask & (SHOST_DIX_TYPE0_PROTEC>
This should probably be put in a .h file instead.
prev parent reply other threads:[~2021-06-04 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 5:11 Yang Yingliang
2021-06-04 5:22 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e841993b4b04a5c1dd2e266f1fe22c7debe8a425.camel@perches.com \
--to=joe@perches.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®