From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE5EC433E0 for ; Tue, 9 Mar 2021 12:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1766A65272 for ; Tue, 9 Mar 2021 12:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbhCIM11 (ORCPT ); Tue, 9 Mar 2021 07:27:27 -0500 Received: from smtpweb147.aruba.it ([62.149.158.147]:39973 "EHLO smtpweb147.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhCIM1T (ORCPT ); Tue, 9 Mar 2021 07:27:19 -0500 Received: from [192.168.1.56] ([79.0.204.227]) by Aruba Outgoing Smtp with ESMTPSA id JbSIl6vHe1jmzJbSIl3MLw; Tue, 09 Mar 2021 13:27:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1615292838; bh=0cefqMk4tclHgG3aICIgkvolMra2WYcEokDzmkS1YSo=; h=Subject:To:From:Date:MIME-Version:Content-Type; b=Jabj857JO8ZgirMb1l+X370ywGH2HwYQpBv8fZJY/sLHStxs+PRrfv9qNwOjbx0OQ haFwtCozjmSN+ei3lZfLwuTzzdGf6GsY3clkXmjeI0a2mXzdPdEBD9nNkkBV1RCH0C lD78uaW4u9fh0rZ+2AUJ5l8E9f3MiIF7Twn3ZnEa2YqUoeB4++vW8CaWgCgJZm6JmS ZSw0mPOC7t1ByaesslGhrfqr7ygP1f5vUnD2XdMzUAWFFWAagT9RxdyW8tWZMVdDcF 1O9VFpqUTbKxkyFidvdAZ6xp559yTGfJz3LtprlIiioKp1VJ51jE2kbK9KHz1BXwTx EqZv2SQeDZB7A== Subject: Re: [PATCH resend v1 5/7] pps: clients: gpio: Make use of device properties To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Ryan Govostes , Greg Kroah-Hartman References: <20210309112403.36633-1-andriy.shevchenko@linux.intel.com> <20210309112403.36633-5-andriy.shevchenko@linux.intel.com> From: Rodolfo Giometti Message-ID: Date: Tue, 9 Mar 2021 13:27:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210309112403.36633-5-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfBPBDYuUTTJm56RDHtYo0YRDYXG0cWj8r6YvkstEykKK4yly2zN7WZVbTdDGiPwGBxfBnOIsgQvoZW8HDbe7uy5zCTnLvwVCPgT88gMT25tTAPZOCQKu bBiNY/KxeIvPmmwIrDhgGjmn7+iXdnsMj4aMByzts4XAHNIBzN9rgXc9DYkTOAAIwd57eRfJVbJDJXIByM5SHnnsMxzrESJWflhKGvqEc1D2Q2e2XcwPs/Cl iHbpxIcKJMuiz4YEljqU1oNNdt7pk5So0g0rnPZFlYmn/t/1OtXLxcL5sV+FFTyz Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/21 12:24, Andy Shevchenko wrote: > Device property API allows to gather device resources from different sources, > such as ACPI. Convert the drivers to unleash the power of device property API. > > Signed-off-by: Andy Shevchenko > --- > drivers/pps/clients/pps-gpio.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c > index 291240dce79e..c6db3a3b257b 100644 > --- a/drivers/pps/clients/pps-gpio.c > +++ b/drivers/pps/clients/pps-gpio.c > @@ -12,14 +12,14 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > #include > #include > -#include > -#include > +#include > #include > #include > > @@ -102,7 +102,6 @@ static void pps_gpio_echo_timer_callback(struct timer_list *t) > static int pps_gpio_setup(struct platform_device *pdev) > { > struct pps_gpio_device_data *data = platform_get_drvdata(pdev); > - struct device_node *np = pdev->dev.of_node; > int ret; > u32 value; > > @@ -121,26 +120,24 @@ static int pps_gpio_setup(struct platform_device *pdev) > "failed to request ECHO GPIO\n"); > > if (data->echo_pin) { > - ret = of_property_read_u32(np, > - "echo-active-ms", > - &value); > + ret = device_property_read_u32(&pdev->dev, "echo-active-ms", &value); > if (ret) { > dev_err(&pdev->dev, > - "failed to get echo-active-ms from OF\n"); > + "failed to get echo-active-ms from FW\n"); > return ret; > } > data->echo_active_ms = value; > /* sanity check on echo_active_ms */ > if (!data->echo_active_ms || data->echo_active_ms > 999) { > dev_err(&pdev->dev, > - "echo-active-ms: %u - bad value from OF\n", > + "echo-active-ms: %u - bad value from FW\n", > data->echo_active_ms); > return -EINVAL; > } > } > > - if (of_property_read_bool(np, "assert-falling-edge")) > - data->assert_falling_edge = true; > + data->assert_falling_edge = > + device_property_read_bool(&pdev->dev, "assert-falling-edge"); > return 0; > } > > Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti