From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38EAE3932E4 for ; Thu, 23 Jul 2026 07:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784790023; cv=none; b=JRG13M6jzul+CFVObsytawgTOqVwEbSUDPZ+olG9RuljuR7eJV7dWaU3dqascKSqJp2V6BHm+zyv+qViSxbUPVyRhmAyBWYBCCobzq9A1hdO9oY1nOpuWIwS5JVLTdJUDC4qxH/wf7b9Nne+HWwVqDaocXs5aSmZT+HCVVRTUDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784790023; c=relaxed/simple; bh=VILMoO/Jv4/7xDOVCpc8wmFeivgVhLgZgo/OL3J+MMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pyNIB0Bu9pmh51N51/mHVNRSSKzKz/9gMAqqHst9COqu9f9MnYC5qKm+LvNX9t/5LseXNqt7hbOMHmFOL72PvhOC4cv5wj501IJiNstLtUoBPIjUbnwBn3upEjyUloJirtnPxFWz08ajUI95VYih1J9OrW8hacziAAv3sSeGRRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dPEo91DZ; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dPEo91DZ" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cacf197759so4997715ad.2 for ; Thu, 23 Jul 2026 00:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784790020; x=1785394820; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Rvc1Q8Yuo59f8Js6D1YtI1CZ2BliYzQWnNcO/qXOPsM=; b=dPEo91DZazOXFD0GDYmjRfOETcT126NZQ9iwDd7QEMHHehbZ7gKJiBfVUOFKzZyReI JX1Q/Vg9L3v5pACCG+/npWYzF+vwT9A9WJVyrw6MTIFxlR1m2iC1KTHAzIjZhSXtjCSd 9VPpDpK8LIWqVEuaJH+OdbP7cXfuKpW5tHBVpT18W9yielPbB6W1e5V12nQmlAAP23xA BTIt5wbPmcLJya6I/xYwMAliOVe0HMtHjkSRrx76T7Jk8RHvM5pBKAldNYmBfkQadFwO OKAyy4rxK8rFjIGFxhE1ZFn/LpSyXO+y6mcLlQmE6AVCFT7ZH24Kg9cUge4h4vCU6i61 x5aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784790020; x=1785394820; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Rvc1Q8Yuo59f8Js6D1YtI1CZ2BliYzQWnNcO/qXOPsM=; b=Atqo0V3CCqU6apGwfkj5TzFHAh8vLKZOz4DlPibypekzqtvFCgfQgekm4t0gK5OwnC MoIfGYQM0scAmS+vPvZ9m3z0frVsnsl8Yw6hjhEp7+00CcQaQEtbSIiVVru1p/BFu95g Qr9IhCqofglOupYDNpujOVkjDpQDMsury+Xf4a49UiBjCTAZ2SpptECaP11om/zAi6md 40GAJQyjjWtHFPUjEKz6HIMlYpmr65I87mvsQg608Fvecjuk3S0NTzrZ+ZMObNB01CT2 iIzp2UKqHGSmNn2uqizNGshLL7J55Q5lranbixR8UiLFt1sb2p8rwavwwDA1EMvpsQ6c YjhA== X-Forwarded-Encrypted: i=1; AHgh+RqsRVoDqrEfalz5bodvDdh68iJ8VJnm6cgbl2AIGLhonGzIrvFpabwGUsq+6M7DzCTn9bgHbqe1STyfh3I=@vger.kernel.org X-Gm-Message-State: AOJu0YyUgNlGSnOtidtQdGxPjwlnE1xowFkVxmH5dD0hiAckyo4RN5P9 aN6FDXwSyjpc14R4R2g4GhSD77t1z7CkfXjCZYPdnONTaqFm5mdrIOl5/I5loB+Z X-Gm-Gg: AR+sD130pTN7An73+uoZYf493zT7xZNBLYqalBZwWYLzNnPFvpkCBd96nYOgYeWHM4D 16SoRiFPpbjMbY/vOKyoNkZGpEgaoUmLIU5pQzlcqaOMpfXJRUgHVWN1pZVq5WOCwSRZmE5wHGd XNBV6IhBQH8oZ/IBGXLp45fuNxgANh5JrVD634sCtNnahB6lxWt0yXZIAkANqarlB8i3YOGejVM rSFGeRnuKtN0bVm+qv/2yRN7kdUGq8ZUxuzTXcRXCyPoDzGaME6Amt5aZkbvfHwO4akCyTNVZNk RIMJWgT/jfzjB9Jjfp9vITZOpOQFlbVXDz/H7+EwTPU2+msGr7b+qFk9gBsq7y/qfIzqw7PrZWM hFphwG8R/3VGxDyobNiuGVCq4zU7amaDBMjNMdxuc0qK8g63MnagMNcwq3+axxdyAwdc1E/3Emb vNDNFLFaSF1HvP0qlDS0JLC+SwjAin4Eetb2Fip+iO0T0Yh1IvRAhp X-Received: by 2002:a17:903:3508:b0:2ca:61bc:317c with SMTP id d9443c01a7336-2cfa71d8e4amr23738485ad.13.1784790020086; Thu, 23 Jul 2026 00:00:20 -0700 (PDT) Received: from [192.168.11.6] (FL1-133-202-37-214.tky.mesh.ad.jp. [133.202.37.214]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f34bb48sm27652235ad.65.2026.07.23.00.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 00:00:19 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 16:00:18 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] fpga: altera-cvp: Propagate PCI config access errors To: Xu Yilun Cc: yilun.xu@intel.com, mdf@kernel.org, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Daisuke Matsuda References: <20260701092633.5146-1-dskmtsd@gmail.com> <20260701092633.5146-2-dskmtsd@gmail.com> Content-Language: en-US From: Daisuke Matsuda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/07/23 12:42, Xu Yilun wrote: > On Wed, Jul 01, 2026 at 09:26:33AM +0000, Daisuke Matsuda wrote: >> From: Daisuke Matsuda >> >> The CvP control path accesses the VSEC registers through PCI config space, >> but several reads and writes ignore the return value. If a config read >> fails, the driver can make decisions from an undefined register value and >> continue programming with bogus status or control bits. > > Searching from the kernel, most pci_read/write_config_dword() don't > check return values. Could you help me understand why they don't but > this driver has the specific need? Hi Yilun, Thank you for taking a look. I agree that the vast majority of drivers do not check the return values, and I don't have a strong reason to make this driver behave differently. I'll drop this patch and send a v2 with only patch 1/2. Thanks, Daisuke > > Thanks, > Yilun