From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751290AbdJWFxp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 01:53:45 -0400
Received: from mout.web.de ([212.227.15.3]:53118 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751043AbdJWFxn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 01:53:43 -0400
Subject: Re: devfreq/exynos-bus: Use common error handling code in
 exynos_bus_target()
To: Chanwoo Choi <cw00.choi@samsung.com>,
        linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <CGME20171022134057epcas4p43e6f37b8994c28f6ef240536349811a8@epcas4p4.samsung.com>
 <4a407cd6-020c-1750-019a-6c0ceb40e245@users.sourceforge.net>
 <59ED4313.701@samsung.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e84ea128-d69e-7c77-db3a-44622457f347@users.sourceforge.net>
Date: Mon, 23 Oct 2017 07:53:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <59ED4313.701@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:jAH/EKF5YW3OT4LBwp6b3vbBfzn61yNXPqz33ARh2YfMNLdHmye
 x9vUBhRV3SBfYyiTvkZqAyvy7CKD11lUksalVh1N5Ft5QNaUSTvDAqC5v2oXU8DzF7MTfQT
 zKFL9FsyUPznoxE1lOeCywIP+GfVhzq+GXilSVsDLDHiktmQgp9zFPG4PAMckBDFrPwDJhs
 VeWBdLLzqGG4gPhiFZEWA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:EEfsN2W5Atc=:1oJQ9wKIYfbudtIa2gQYTi
 WRK0K1pZTcPsq0oglKX6FLiBLvd6gWDiJB4+Qj9pLolfBnfS8ilVh5iMekB+uFWsPD7af15p+
 GyYxaZNeR3TLTOl7uA0IE8yMcUCvJjbGDtPokiKZhpnC8FbWKGS5tpWo6xUM6S42IjJMdZKdw
 fiS13nfu3JRxPvHf2MhKN17CX7RUseFVXfx7a5ETBA4J1Tc4YA2tah8z00jn7WaeCTwnQUi85
 z06YlLGF5wsp0mngbVQVam3SGm9KF0t9ui69n4zFv5K3NcU9f+qcoX9z/E29mcyOzp6Q9Vjtx
 KtT6sJGTBJbsXTCXcHQeRP95qdkMS7AoKZdabY19OWu5bMZ3fRMFpEFmrtTK9fu3KR1qrdh1E
 sKiQHJIXYJLzjjXdknnd1M8xiNMS1hNQ3bowM19E5ILES6Or1QzjKfLXuTjS8qNDrZbj06lop
 +a5OCASb4ppq06gMa3F2dYj33ZVRrNbFcUX3dl7HhTlK4CbPvlWJGLwhWzFdtUaCX66QvN+MI
 xvCx08h6rNdQpWZOnPknFexM3XnIZfekdYpbOItmZih1pm3quqMGC7P6NqURD+U6FDd0CMhPs
 in8z6gVt7dlmn2k64zZ8NZ9aFuaiNqiBk3CYc/DinX/qisQOXcrOiTPHzpqh1nLwW/ZxKt6dg
 xSyAD1pUUxO+LaQSHGiuezzoWObJayGaOf48sC8cinMSs8chuk3cF6mhMez/dp5iIRkFB5VmB
 yyqkCt+O1kKig6Kl61j7B2/5iOYEGsO4eZpKkdcWs5I4hGXgwv8H1qtd4Ba+n7gs62LH7xu6t
 eDFzwBbCD4qiAxnfjkVFBOSjt0Y2+SEjryvtwUBi8/r3JR+ibk=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> As I already commented on your other patch related to extcon-max14577,
> this patch might remove the redundant error message.

I hope that more software improvements can be achieved in this design direction.


> But, it makes the code more complicated in side of readability. I prefer existing code.

I prefer to avoid duplicated code a bit more.

Regards,
Markus