From: Matti Vaittinen <mazziesaccount@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()
Date: Mon, 21 Nov 2022 13:33:16 +0200 [thread overview]
Message-ID: <e84f8d00-616e-14d7-5427-61065c88c015@gmail.com> (raw)
In-Reply-To: <20221121102454.15664-1-u.kleine-koenig@pengutronix.de>
Thanks Uwe!
On 11/21/22 12:24, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/mfd/rohm-bd9576.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index f37cd4f27aeb..c854ab5bcd80 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
> .irq_reg_stride = 1,
> };
>
> -static int bd957x_i2c_probe(struct i2c_client *i2c,
> - const struct i2c_device_id *id)
> +static int bd957x_i2c_probe(struct i2c_client *i2c)
> {
> int ret;
> struct regmap *regmap;
> @@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
> .name = "rohm-bd957x",
> .of_match_table = bd957x_of_match,
> },
> - .probe = &bd957x_i2c_probe,
> + .probe_new = &bd957x_i2c_probe,
> };
> module_i2c_driver(bd957x_drv);
>
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2022-11-21 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 10:24 Uwe Kleine-König
2022-11-21 11:33 ` Matti Vaittinen [this message]
2022-12-08 12:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e84f8d00-616e-14d7-5427-61065c88c015@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®