From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Olof Johansson <olof@lixom.net>, Tero Kristo <t-kristo@ti.com>,
Thierry Reding <treding@nvidia.com>,
Carlo Caione <carlo@endlessm.com>, Nishanth Menon <nm@ti.com>,
Jean Delvare <jdelvare@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] psci: add CPU_IDLE dependency
Date: Mon, 31 Jul 2017 11:19:39 +0100 [thread overview]
Message-ID: <e8580a81-5cca-462c-24c1-30232e19462e@arm.com> (raw)
In-Reply-To: <20170731085523.320244-1-arnd@arndb.de>
[Apologies for the resending, damn Thunderbird sending HTML...]
On 31/07/17 09:55, Arnd Bergmann wrote:
> I ran into a build error for the psci_checker:
>
> drivers/firmware/psci_checker.o: In function `psci_checker':
> psci_checker.c:(.init.text+0x528): undefined reference to `cpuidle_devices'
>
> As far as I can tell, this is simply a very rare combination of options,
> but the problem has existed since the code was initially added.
> Adding a Kconfig dependency makes it build properly.
Good catch! For some reason I missed this config option when figuring out the
dependencies... I wonder though, shouldn't cpuidle.h declare cpuidle_devices
conditionally on CONFIG_CPU_IDLE?
> Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Kevin Brodsky <kevin.brodsky@arm.com>
Cheers,
Kevin
> ---
> drivers/firmware/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 6e4ed5a9c6fd..1983e6e0106f 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -10,7 +10,7 @@ config ARM_PSCI_FW
>
> config ARM_PSCI_CHECKER
> bool "ARM PSCI checker"
> - depends on ARM_PSCI_FW && HOTPLUG_CPU && !TORTURE_TEST
> + depends on ARM_PSCI_FW && HOTPLUG_CPU && CPU_IDLE && !TORTURE_TEST
> help
> Run the PSCI checker during startup. This checks that hotplug and
> suspend operations work correctly when using PSCI.
next prev parent reply other threads:[~2017-07-31 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 8:55 Arnd Bergmann
2017-07-31 10:19 ` Kevin Brodsky [this message]
2017-07-31 14:14 ` Jean Delvare
2017-07-31 16:22 ` Kevin Brodsky
2018-01-19 15:18 ` Arnd Bergmann
2017-07-31 12:34 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8580a81-5cca-462c-24c1-30232e19462e@arm.com \
--to=kevin.brodsky@arm.com \
--cc=arnd@arndb.de \
--cc=carlo@endlessm.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=t-kristo@ti.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®