From: Rodolfo Giometti <giometti@enneenne.com>
To: Jonathan Cameron <jic23@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Angelo Dureghello" <adureghello@baylibre.com>,
"Tobias Sperling" <tobias.sperling@softing.com>,
"Eason Yang" <j2anfernee@gmail.com>,
"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
duje@dujemihanovic.xyz, herve.codina@bootlin.com,
thomas.petazzoni@bootlin.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
Date: Mon, 2 Nov 2026 08:37:02 +0100 [thread overview]
Message-ID: <e858ddf4-4710-4908-b2e7-d26a68d06fbb@enneenne.com> (raw)
In-Reply-To: <20261031234848.00248ddd@jic23-hlaptop>
On 01/11/2026 00:48, Jonathan Cameron wrote:
> I'd also like to avoid propagating the fallback to all channels
> if none are specified. In this particular case it is problematic
> because if you add the GPIO mode, for chips like this, we tend
> to expose all pins that aren't in use for anything else as GPIOs.
> With the fallback scheme you have no way to tell if you want all
> pins as GPIOs.
Agreed. With only 8 pins, listing the channels explicitly in the DT
costs little, and it keeps the door open for the GPIO support.
Maxime, if you drop the fallback, I think the commit message of patch
1/2 should lose its last sentence too ("If no ADC chan description is
represented, all channels will be exposed as analog inputs."), since
it would no longer describe what the driver does.
Thanks,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming
next prev parent reply other threads:[~2026-11-02 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 16:47 [PATCH v2 0/2] Add driver for the TI TLA2528 i2c ADC Maxime Chevallier
2026-10-30 16:47 ` [PATCH v2 1/2] dt-bindings: iio: adc: add Texas Instruments TLA2528 Maxime Chevallier
2026-10-30 18:34 ` Conor Dooley
2026-10-30 16:47 ` [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc Maxime Chevallier
2026-10-31 17:30 ` Victor Chernyakin
2026-10-31 23:48 ` Jonathan Cameron
2026-11-02 7:37 ` Rodolfo Giometti [this message]
2026-11-02 7:22 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e858ddf4-4710-4908-b2e7-d26a68d06fbb@enneenne.com \
--to=giometti@enneenne.com \
--cc=adureghello@baylibre.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=herve.codina@bootlin.com \
--cc=j2anfernee@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marilene.agarcia@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®