From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BD2A3988FF for ; Wed, 20 May 2026 08:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779267287; cv=none; b=p5++l2mt3BH9W5WYnxyfbEaGvVP7SWrhr+j3cVC7ss9J6xPekpibYlKaze5rNUsuEeewOGAZBaVI8APTaqxeb2qcjmjunCZ4/pgmhN5M3A/VPpmfUrZA45cwOKS4+vJ4fg3bUjp0ywcyZlKNCQLS9089PrBVr/+/gEJmNN/CpNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779267287; c=relaxed/simple; bh=CjTV8QBGlydhsyVQTzRqgueRHR67e1eAIahXmknwPMI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cq5pVEb6PAGXOUVMSYoMwrldb9LD8AHBoGcGJ6GiFAc/49PzcR9a59KLwdpjW1Sk/OvBhautD64cbn+BeHVJGm8Vr2jHiKDPa/mFIakUeAJYshfksHGIYClfUFwShUsEqhrmgLVFxKrivefML2c4/cPlxfz4v5GAgmUzoJGPi0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dFzYwxZl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I6zvw6tK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dFzYwxZl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I6zvw6tK" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K6r8Ys341460 for ; Wed, 20 May 2026 08:54:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /JjcwkslOcMmSQKpp5qTUuofPFeLxCYtN8XgHirflsY=; b=dFzYwxZlmhYIfXwW hJ31t9G40Xdhl+Z8NorAhDxeAA6qXhJQarZtIHQyUKxtV6oYtEf1MQ0ymTMKGdLP BLX+e//cECCHLFjNN82L7Xugcn7RKH7xtrWgjvWdBKm+PTbDAAk1/0+T9CAh6FB/ /82TqvkudSjE+37Q4Pdhlb/rXusviqRkpaUTjXw9zWl4ZJXcbhaxf3cLEUbfN5vq listlmPxfKfQayqb+1A2uBI3ZykT69b0aX2HYseMxfg4vj4J+gKIGvF4lmVrSrye hp0ExjDneVLQvd/3QTPUEyGndDynErfjXqnkTRadLpxO/A9VphjGk0O9tjNqVnE1 wV4fVA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3vbveu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 08:54:45 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b2ecc96a9aso52080395ad.1 for ; Wed, 20 May 2026 01:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779267284; x=1779872084; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/JjcwkslOcMmSQKpp5qTUuofPFeLxCYtN8XgHirflsY=; b=I6zvw6tKSxNk30/5rU25fhEhf8csxx9C20bBsQp+hovEGu8Dvmn1JLSSSPwzsfqt+G L/YzBAehuTbUrwy07gZw7/7D36ME/b5oOIGPhIvUaGVndxNAT5yCyfCnDr7kFrY3cM/P eBewqnQ4GTGYiEc/9wZhTEBvLd6XDXi76bzHxjBIwgQ6SMxV25wIncbAMHNx/dY0C4vA BnIYSC2ilwncLjCIAN4xBgqULNcnFRU+8T0E3qQ4aCaVqkW1fcloixetfb1cb9YmpYPZ 5Rqi/kgREEOYK/s8Ht4fQavcLLncHQfWsziF8X8o+Piu+lNOCU6+X7YS0+Ij6CyykY+m P9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779267284; x=1779872084; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/JjcwkslOcMmSQKpp5qTUuofPFeLxCYtN8XgHirflsY=; b=f9XjgT2QiY+LgGZNODj5E9nWMOM55flGN/IRyqpL68lAVtTuYd0zA/Dwq79b/DmYnK kOL4t7drTao2fdbZd20MTBGAmLhRoqJrbpWkuDvrAa+ZnSDImBIx2wzs6HagK9pZOIpt Kf1Zn+PIBH/v596glD18vCrRLVHA1Uy3vjA/oo2LQgrz+9PmE1MCX1Cl7ga2JSsT+s3z JJX8DmpiXWwBNFt2cO7h0cIeemw/ahY3HcrtfVJ9mWZ003RiMh0uq1LQ+nZDLDQHDIgm db55tfs6qcrLNGgnnWMe1pE7DNGs7QqZeACad8MfXnfLgjPK+6psxoUyvHQREXrO5GBW h0kw== X-Forwarded-Encrypted: i=1; AFNElJ/7GRtQ03vXuDhzj70uzXfA+Gv5TujDqQtNiEZL7xUhmMOeBJ4SJ4gF18n7p2GIdmpTu7JLgRBPyTfNEKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yym3/6+dPr/1CY16SHzd9lV7nu3jU1OIQl+7athGujrXpKG3g6Z 1kO574LxJrVOnR7NWCPTYF+VFthfarACbxfRFksUURmaAMsMS0SdvzCYxgsrkuWrJC+Ukb7TdFF lGgjw8GzVWUbi/DMRiIAFPQFrvwBpvyuYfe/cMw1pl62sDW3LExeWrZAo6iLly3nPtdQ= X-Gm-Gg: Acq92OFIxME1xXVeEdv9ouT3tZxuLOT+yJbR2q6rQQa9xqcCDqlq7VVzY5DyG4io2+y eio2wEfFJwG+tYpXjaMZZI0BdLw47Y82ijMt9y3KnrsOTXpjj/sVaCQw0qP5QL3KPsiTrIr5gM3 SeSxaTGt4/wPjIsTT/tx11NPFFo+KVstORmM40xnFlwNueGPVtcbGIT0x6K6sNqCKs8dWSJ/hcw QF9bth+xs2UqWbMTURAnay5u2C89bweRUOxlM6AFU/bk/fZzNUfan5LMw8qv8JiKzl6a52opauf zc92sm41+qMX2BXvH0DD3I281Z1fZpfnqHoHCsj3XOaSp8cqS0VF4xDzzLpP0F2phMyP3WubI52 pnEJSzGlx1bS4WPc6tWHoID9VE7lwuxqofu4ku9bDa0gnPjR0GPlWLuRKur21QBJ1P3tRkuOmTY 9kS628htHSHhFmtYRd1w== X-Received: by 2002:a17:903:1b6e:b0:2ae:803e:6c12 with SMTP id d9443c01a7336-2bd7e8ae6f6mr267807525ad.6.1779267283901; Wed, 20 May 2026 01:54:43 -0700 (PDT) X-Received: by 2002:a17:903:1b6e:b0:2ae:803e:6c12 with SMTP id d9443c01a7336-2bd7e8ae6f6mr267807325ad.6.1779267283412; Wed, 20 May 2026 01:54:43 -0700 (PDT) Received: from [10.133.33.114] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d1062e9sm214505145ad.67.2026.05.20.01.54.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 01:54:43 -0700 (PDT) Message-ID: Date: Wed, 20 May 2026 16:54:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/39] drm/msm/dp: introduce stream_id for each DP panel To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-13-b20518dea8de@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: eFY_ppXfb70gh8NNrN-aOJsE0EN1I513 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDA4NCBTYWx0ZWRfX9CH4N0nlAtkj varyVvPNzNzufGMjpqnhgVvmCxtfVuDCYGA4LadsaxeFLi9dS2oSYIt7+lDIJv9LbT7kQvaHa2M 84s1V6ps64rGSW7bT/IeIHNfrCBj6CHit/I73Wd1Y1HX1ReKICWb09l1aMvRSk7Xp/6RL8W7KMQ twwIC94Z80hD6W+rBvAQVYUGtiZ8DM5q3A0dVbx0CGlgLjf6XwpYf9pZYdvwEfGLvxg329Bn1Di aGD8/mWPcA8L/b9OW+zjprylhywKtDLIWC+p4fyzfscgHR60KWeUViO6aYkgnfDsMj48X/2Ms44 TRR/tx94b1RZWJfkqrtwxyH6ShLwTwU3U3LUmFU12AyPSpsz36SiR/pnCNN3s6QTV01DJFBY4f5 1Pq+XGNOBQxB/X+xpqfrlCe0NEkgPpv/Ar+t9nWVo9FU89x7rbPML1TMDsRgoEZqsqwrE7Z2OHb FscbLj8KSfJo5K1Rlhg== X-Authority-Analysis: v=2.4 cv=JuPBas4C c=1 sm=1 tr=0 ts=6a0d76d5 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=8Wk7F6lNGgSB0avDr_YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: eFY_ppXfb70gh8NNrN-aOJsE0EN1I513 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200084 On 4/12/2026 8:04 AM, Dmitry Baryshkov wrote: > On Fri, Apr 10, 2026 at 05:33:48PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> With MST, each DP controller can handle multiple streams. >> There shall be one dp_panel for each stream but the dp_display >> object shall be shared among them. To represent this abstraction, >> create a stream_id for each DP panel which shall be set by the >> MST stream. For SST, default this to stream 0. >> >> Use the stream ID to control the pixel clock of that respective >> stream by extending the clock handles and state tracking of the >> DP pixel clock to an array of max supported streams. The maximum >> streams currently is 4. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 57 +++++++++++++++++++++++-------------- >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 2 +- >> drivers/gpu/drm/msm/dp/dp_display.c | 24 ++++++++++++++-- >> drivers/gpu/drm/msm/dp/dp_display.h | 2 ++ >> drivers/gpu/drm/msm/dp/dp_panel.h | 11 +++++++ >> 5 files changed, 71 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c >> index 120ec00884e5..fb6396727628 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c >> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c >> @@ -127,7 +127,7 @@ struct msm_dp_ctrl_private { >> unsigned int num_link_clks; >> struct clk_bulk_data *link_clks; >> >> - struct clk *pixel_clk; >> + struct clk *pixel_clk[DP_STREAM_MAX]; >> >> union phy_configure_opts phy_opts; >> >> @@ -139,7 +139,7 @@ struct msm_dp_ctrl_private { >> >> bool core_clks_on; >> bool link_clks_on; >> - bool stream_clks_on; >> + bool stream_clks_on[DP_STREAM_MAX]; > > drivers/gpu/drm/msm/dp/dp_ctrl.c: In function ‘msm_dp_ctrl_core_clk_enable’: > drivers/gpu/drm/msm/dp/dp_ctrl.c:1937:9: warning: the comparison will always evaluate as ‘true’ for the address of ‘stream_clks_on’ will never be NULL [-Waddress] > 1937 | drm_dbg_dp(ctrl->drm_dev, "stream_clks:%s link_clks:%s core_clks:%s\n", > | ^~~~~~~~~~ > > Emm. thanks will fix this next vesion.