From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org,
"Greg KH" <gregkh@linuxfoundation.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-actions@lists.infradead.org,
linux-unisoc@lists.infradead.org
Subject: Re: [PATCH v2 5/6] serial: Use UART_XMIT_SIZE
Date: Thu, 23 Jun 2022 09:30:09 +0200 [thread overview]
Message-ID: <e864ffbc-5885-f648-01c4-68a598f942b9@kernel.org> (raw)
In-Reply-To: <20220621124958.3342-6-ilpo.jarvinen@linux.intel.com>
On 21. 06. 22, 14:49, Ilpo Järvinen wrote:
> --- a/include/linux/serial.h
> +++ b/include/linux/serial.h
> @@ -9,7 +9,6 @@
> #ifndef _LINUX_SERIAL_H
> #define _LINUX_SERIAL_H
>
> -#include <asm/page.h>
> #include <uapi/linux/serial.h>
>
> /* Helper for dealing with UART_LCR_WLEN* defines */
> @@ -25,11 +24,6 @@ struct async_icount {
> __u32 buf_overrun;
> };
>
> -/*
> - * The size of the serial xmit buffer is 1 page, or 4096 bytes
> - */
> -#define SERIAL_XMIT_SIZE PAGE_SIZE
> -
> #include <linux/compiler.h>
>
> #endif /* _LINUX_SERIAL_H */
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 5518b70177b3..1767dee98021 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -296,6 +296,7 @@ struct uart_state {
> struct uart_port *uart_port;
> };
>
> +/* The size of the serial xmit buffer is 1 page, or 4096 bytes */
That is not completely true, I'd remove the "or" part. Hmm, but then the
comment is somehow superfluous as it says what we can see below. So
maybe don't add it at all?
> #define UART_XMIT_SIZE PAGE_SIZE
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-06-23 7:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 12:49 [PATCH v2 0/6] serial: A few cleanups Ilpo Järvinen
2022-06-21 12:49 ` [PATCH v2 1/6] serial: msm: Convert container_of UART_TO_MSM to static inline Ilpo Järvinen
2022-06-23 6:24 ` Jiri Slaby
2022-06-21 12:49 ` [PATCH v2 2/6] serial: msm: Rename UART_* defines to MSM_UART_* Ilpo Järvinen
2022-06-23 7:26 ` Jiri Slaby
2022-06-21 12:49 ` [PATCH v2 3/6] serial: Use bits for UART_LSR_BRK_ERROR_BITS/MSR_ANY_DELTA Ilpo Järvinen
2022-06-23 7:26 ` Jiri Slaby
2022-06-21 12:49 ` [PATCH v2 4/6] serial: 8250: Use C99 array initializer & define UART_REG_UNMAPPED Ilpo Järvinen
2022-06-23 7:27 ` Jiri Slaby
2022-06-21 12:49 ` [PATCH v2 5/6] serial: Use UART_XMIT_SIZE Ilpo Järvinen
2022-06-23 7:30 ` Jiri Slaby [this message]
2022-06-24 20:00 ` Ilpo Järvinen
2022-06-21 12:49 ` [PATCH v2 6/6] serial: Consolidate BOTH_EMPTY use Ilpo Järvinen
2022-06-23 7:41 ` Jiri Slaby
[not found] ` <CAHp75VeKhY6dN7j_yXQXUMhOqRwqQ2yN_qF95U9wU6K4uKPdaQ@mail.gmail.com>
2022-06-23 8:24 ` Jiri Slaby
2022-06-23 10:15 ` Andy Shevchenko
2022-06-23 10:17 ` Andy Shevchenko
2022-07-04 6:59 ` Jiri Slaby
2022-06-24 21:09 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e864ffbc-5885-f648-01c4-68a598f942b9@kernel.org \
--to=jirislaby@kernel.org \
--cc=afaerber@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-unisoc@lists.infradead.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®