From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757764AbdEVRSV (ORCPT ); Mon, 22 May 2017 13:18:21 -0400 Received: from goliath.siemens.de ([192.35.17.28]:39778 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbdEVRSR (ORCPT ); Mon, 22 May 2017 13:18:17 -0400 Subject: Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency To: Andy Shevchenko Cc: Lee Jones , Linux Kernel Mailing List , Sascha Weisenberger References: <5d426b5dd107daa3524123392f8f15b0b47c09dd.1495450431.git.jan.kiszka@siemens.com> From: Jan Kiszka Message-ID: Date: Mon, 22 May 2017 19:18:14 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-22 19:12, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka wrote: >> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. > > What's wrong with current approach? I suppose this will make sense > when we will have an issue / impediment. Right now it looks like > over-engineering. > > (Yes, I know what I said to you about this earlier, OTOH see above) > It allows matching on additional DMI tags without additional code - patch 2 depends on it. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux