From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Taniya Das <taniya.das@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Alexandre Mergnat <amergnat@baylibre.com>
Subject: Re: [PATCH v3 2/6] clk: qcom: negcc-nord: keep GPU2 CFG clock enabled via critical CBCR
Date: Tue, 13 Oct 2026 12:40:05 +0200 [thread overview]
Message-ID: <e8689aae-db6f-41ec-8584-f2d8f105eace@oss.qualcomm.com> (raw)
In-Reply-To: <oqi2xquf7w5qahh5ufeecmkpy2qhfenu6v33t3vbz43nsph2q5@cseg4p3vlnyh>
On 10/13/26 12:36 PM, Dmitry Baryshkov wrote:
> On Tue, Oct 13, 2026 at 05:54:44PM +0800, Shawn Guo wrote:
>> On Tue, Oct 13, 2026 at 11:08:56AM +0800, Shawn Guo wrote:
>>> On Fri, Jul 24, 2026 at 04:25:06PM +0530, Taniya Das wrote:
>>>> The GPU2 CFG clock must remain enabled for correct operation and
>>>> should not be exposed as a controllable clk_branch.
>>>
>>> Hi Taniya,
>>>
>>> Could you share a bit more information why this is the case? I do not
>>> seem to get any problem when testing without this change.
>>
>> Never mind! I can see the issue it fixes now.
>
> Would be nice to capture it in the commit message.
https://imgs.xkcd.com/comics/wisdom_of_the_ancients.png
Konrad
next prev parent reply other threads:[~2026-10-13 10:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 10:55 [PATCH v3 0/6] clk: qcom: Add Nord multimedia clock controller support Taniya Das
2026-07-24 10:55 ` [PATCH v3 1/6] clk: qcom: gcc-nord: mark PCIe link clocks as critical Taniya Das
2026-10-13 10:37 ` Dmitry Baryshkov
2026-07-24 10:55 ` [PATCH v3 2/6] clk: qcom: negcc-nord: keep GPU2 CFG clock enabled via critical CBCR Taniya Das
2026-10-13 3:08 ` Shawn Guo
2026-10-13 9:54 ` Shawn Guo
2026-10-13 10:36 ` Dmitry Baryshkov
2026-10-13 10:40 ` Konrad Dybcio [this message]
2026-07-24 10:55 ` [PATCH v3 3/6] dt-bindings: clock: qcom: Document Nord display clock controller Taniya Das
2026-07-24 10:55 ` [PATCH v3 4/6] clk: qcom: Add Nord display clock controller support Taniya Das
2026-07-27 15:14 ` Alexandre Mergnat
2026-10-13 10:43 ` Dmitry Baryshkov
2026-07-24 10:55 ` [PATCH v3 5/6] dt-bindings: clock: qcom: Document Nord GPU clock controllers Taniya Das
2026-07-27 15:15 ` Alexandre Mergnat
2026-07-24 10:55 ` [PATCH v3 6/6] clk: qcom: gpucc: Add Nord graphics clock controller support Taniya Das
2026-08-03 3:24 ` [PATCH v3 0/6] clk: qcom: Add Nord multimedia " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8689aae-db6f-41ec-8584-f2d8f105eace@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=amergnat@baylibre.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®