From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B49F35CB8C for ; Sun, 9 Aug 2026 12:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786278828; cv=none; b=S+qeD7wdunR7SHknrXCMfr1t50qXnSK98mpC6x4S3+XlteItLJcpa8f8FYfR8UB2I9gRopeBYzJmcJ/iyLTUrBuBzLBtEXDR2fwo0jJooLAWTpyqm+bCgWHIKOL8Abjvos9idaehYLEgtlScOfWDkTc/KRyKtQBMRkUi+6dHpxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786278828; c=relaxed/simple; bh=510uDvyd32sgzhlGwCfHMT1JRWWiRprn1MywQxgm3J8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=jOS7zyGqxkMlupZE8N1yGExtwK6yi/JXPSfoxHCsA6CRhMpCZjdubUKBEBlHk9ESdPZn8vt9vi2xqGau1hqKchiHWNW6lqQ0PAAEb+czehFuyRKFaWFXqN/Fmm4QgpVsLrU+8EvmaxVJaMQodxccShf+zXV9e6laBtvttHL1+KU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OVQ8uHC3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NthjEQMD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OVQ8uHC3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NthjEQMD" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 679C1RmA1944933 for ; Sun, 9 Aug 2026 12:33:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IrQTEGA1d6JWldRyNS6hURK+2Oil921Orn6sio9wxXY=; b=OVQ8uHC3XxA7Q8nv XVGk46q9ZuwlwnDZTmfQ/bk6+36LWyl2TFmbWnuqA11kgxHJKEs7HQKz6EK1e4e6 Vcr6jLRu7sgzUCREkzclgY7Vkjgi4lFYMIFzO0vv9RnnsrKdXcrGbCKVpZr1SrPA yjvrY5+Z5banNVDsyFhd5HDqRYhuEmfa+D+0q1mcB6ToeRsKFp1zRLd8FZyP7JQL ha3qZnt+aKs/mOlJ1RW8OKoVIeNHI5m7C71C9ZJbGdTzYSdszyA+qAJkMh6SaAc8 iHOjt5H0HBn3Ievggl5+cODUR56kKkMfT8QdZFQiyCs/OVuWmgUQgfAsX85Egr8W uFDbPw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fwwmgtrmp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 09 Aug 2026 12:33:46 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb4cdf95b5aso2269611a12.1 for ; Sun, 09 Aug 2026 05:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786278826; x=1786883626; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=IrQTEGA1d6JWldRyNS6hURK+2Oil921Orn6sio9wxXY=; b=NthjEQMDOKPlMK9gv4ep8oAZ2y4ZUpBCVNWIPzYL8DFZF9JA+EYEP7VdsePsOCPTbg gdtCguCplDK3D5dGtdAeETPJAkk4UtqoCGMM0hPgykFggzWSiNa7wH30zpA4b7EA1OfV AD/oI89r33jHM3QaQCUaCR9Yzm6uzTRYSDybjyOr4keMlfPJ+CH/o5HsPIM2eZgTCZZg 2a8sXM4c45jjDV0iRkICAN5bUTGgXr1Xqj8Ue7jzB7QNmLc9GBi/HqLfrS86BCi/9Z5V 2Gt6gYuF45kFMKA4MhikEdKas5J6f9bZwOJnC/1ngvolhLVZL41sob7Y1USTeVG1lDox ETIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786278826; x=1786883626; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IrQTEGA1d6JWldRyNS6hURK+2Oil921Orn6sio9wxXY=; b=jGtdeoB6Mly6KvbfhWwOufSiKPadZhSfkOBHictT/Mlc7bdTr9nUFZp4WzUEQpOat/ cJ/jOnmEr6qHrkSddnLEggqPA7y0VOtbSSLNWMT9hCT1pVoPHOCu+jMmEmmDuMd4CA1A ERgHTjId0BrSzWTGUrp48wgW7ddRVWQjCLdGRIFB7cRzZgqH6Pmgg4yz0GZdiu5IplII dnDK42vwNqoKhkyORN/fK5Kwn7sHBULqBWWlUROxCwKJyFmQbqNyeZuboybS96q1icUS i9cUg+E0NjcQjG07t1l2vTx6qwC8um4GepZ0EWSx8qCVUpIr8Mr79rJK4OI7fE3NdgJp ot7w== X-Forwarded-Encrypted: i=1; AHgh+Ro8KB2f+ZpM3TFMwZHiRILYsqpZpMPbM7X+cyiooSIA1nTLgRt5qDajt+h5olQ8OmgYbAk8zg4NlYy4zkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzVTySlHCXZ/BmIupUuyi4C0kDK+2vQCGvtlU9VLfWUu0zngtxV jxdxLCIlYJrFXqYHyuMTIaZDqIf5gZL0T6YxKtxDq4u2S2ZLagXQTnjjWJhoY7FuJBcPL2gwhqT cq9Ov+OJMxuHzuFi2N0DiEjx4hd0dI8MfVU9sG9ZncnCwboZ4NS9bWJN4MhLM+5FeOt0= X-Gm-Gg: AR+sD13cg9fD9+O855GxXxFuZKT/2Af+/NXkdH1hQzbFLJLAonHwdzLZQ+qODC28AvR aMx4R1d0SsmgtKLdmS4MTYQrjoy8t/FS+VORK0gmBFVJGobYtdwMal4I1FKNEzvydkLS61TXt1L C8t4QBDplnYHHZRxQThhN0/VCoJI8FGBVFQmGatJ6BTTtIrQFEqDsF0lu5i22R5dJ3EQ/5BnoVe wQv2IOw0vwNdrIISvphR9Ry/8hyLKjGVHI74leqRhUMyDaU5CwAnRq40L4M1TewJw0ATHOk7xOH b+/fFxmxr83mrl00tVf7jTWFWsMdzMKOBRY76aVS2XIoqRVHkAvY+Ev2XJZefLho55Sl+G8n4h+ u3FouYKK7VprU2wOIzF1yLtAk6f7BSmQ= X-Received: by 2002:a05:6a20:d38f:b0:3b4:8bc6:138 with SMTP id adf61e73a8af0-3cbc03b5526mr19993949637.23.1786278825822; Sun, 09 Aug 2026 05:33:45 -0700 (PDT) X-Received: by 2002:a05:6a20:d38f:b0:3b4:8bc6:138 with SMTP id adf61e73a8af0-3cbc03b5526mr19993897637.23.1786278825370; Sun, 09 Aug 2026 05:33:45 -0700 (PDT) Received: from [192.168.1.16] ([106.222.229.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bec128a0sm34798229eec.25.2026.08.09.05.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Aug 2026 05:33:44 -0700 (PDT) Message-ID: Date: Sun, 9 Aug 2026 18:03:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 9/9] arm64: dts: qcom: hamoa: Enable CDSP cooling From: Gaurav Kohli To: Stephan Gerhold Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Manivannan Sadhasivam , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, manaf.pallikunhi@oss.qualcomm.com, Dipa Ramesh Mantre , Dmitry Baryshkov References: <20260731-b4-qmi-tmd-v7-0-3befd44403d5@oss.qualcomm.com> <20260731-b4-qmi-tmd-v7-9-3befd44403d5@oss.qualcomm.com> <34998a81-864e-42fa-904f-2e5f3490fcf3@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <34998a81-864e-42fa-904f-2e5f3490fcf3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODA5MDExMSBTYWx0ZWRfX2RFYzjzJoInn 14lioedYF6OYz8651GokSei5zHIgl6tFv0pP6mM/AzzsOIoL5Y4L2mbSJ5uUZ5l8W0dFtIpI+/N W/WjTzyCtTliAjI1vxa53l50oHXZDWY= X-Authority-Analysis: v=2.4 cv=HodG3UTS c=1 sm=1 tr=0 ts=6a7873aa cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=x3UvaR+l8cLCJ1uKBUlNag==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=y4XuuB6ikNK3uoXrSYsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: KQLHaQ3srC1GHk9Pr-BnbjL6rvB1WxSH X-Proofpoint-GUID: KQLHaQ3srC1GHk9Pr-BnbjL6rvB1WxSH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA5MDExMSBTYWx0ZWRfXzYEzNfGUiBcC ahSN00NRm2QLHIBzuTorM/tHvicMgHaau4VzhaQjoFSZoarK9WIqK4mb5OUaVzRuHYfrb+rITs5 ebHbvNpcxrzuid6Zte20tkTcX6pkR6DHL98mTATErxhfPfJPLtWzqKaX0TkzFYNdIRP+p4oohKr 9yVbuxfhNcdffLh6PtlRDt5laq/BMdGO0N5J8+WlRQx7qY8VvZBZoVA9hI81+CQXshT6B5vTBRI gl10DC1Zw+mip8D2YS5UjMLImFdWSqPzBE29wHIWv3400+klfyqW9x/9FtUkHlR3cwQhanKXx4U YOIA2T+em/wpEwMpIMPhdTmxRU/MICSeU0yeFHebdLOcEEhf1BC/d9i6JQSNcs7IqPiSmohPRo8 QuXsQs+dJcJ+lRPs1Trtn6Uoi8n+HUSiXlt9dZgP1OPJyhJVX5Uf00dEwWnrtk+nKyke4O1m22M h3uoVbMe1jmi3qhgqrg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-09_04,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608090111 On 7/31/2026 6:52 PM, Gaurav Kohli wrote: > > > On 7/31/2026 4:50 PM, Stephan Gerhold wrote: >> On Fri, Jul 31, 2026 at 04:03:49PM +0530, Gaurav Kohli wrote: >>> From: Dipa Ramesh Mantre >>> >>> Unlike the CPU, the CDSP does not throttle its speed automatically >>> when it reaches high temperatures in hamoa. >>> >>> Set up CDSP cooling by throttling the cdsp, when it reaches 95°C. >>> >>> Add polling-delay-passive so the governor periodically evaluates >>> the zone during passive cooling and steps up cooling levels when >>> temperature stabilizes below the next trip. >>> >> >> Would be good to mention why you are treating hamoa-iot-evk differently. > > thanks for review, will add the reasoning. > >> >>> Signed-off-by: Dipa Ramesh Mantre >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Gaurav Kohli >>> --- >>>   arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 32 +++++++++++++++ >>>   arch/arm64/boot/dts/qcom/hamoa.dtsi        | 63 +++++++++++++++++++ >>> +++++++++++ >>>   2 files changed, 95 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/ >>> boot/dts/qcom/hamoa-iot-evk.dts >>> index 9fa86bb6438e..a146be1cb5fb 100644 >>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts >>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts >>> @@ -1684,4 +1684,36 @@ trip-point0 { >>>               }; >>>           }; >>>       }; >>> + >>> +    nsp0-thermal { >>> +        trips { >>> +            trip-point1 { >>> +                temperature = <105000>; >>> +            }; >>> +        }; >>> +    }; >>> + >>> +    nsp1-thermal { >>> +        trips { >>> +            trip-point1 { >>> +                temperature = <105000>; >>> +            }; >>> +        }; >>> +    }; >>> + >>> +    nsp2-thermal { >>> +        trips { >>> +            trip-point1 { >>> +                temperature = <105000>; >>> +            }; >>> +        }; >>> +    }; >>> + >>> +    nsp3-thermal { >>> +        trips { >>> +            trip-point1 { >>> +                temperature = <105000>; >>> +            }; >>> +        }; >>> +    }; >>>   }; >> >> Please avoid overriding node values like this... One quick rename of one >> of the involved nodes and this will be silently broken without compile >> error. Nowadays dtbs_check will *probably* catch these, but if you >> override values using the label reference you would notice it >> immediately when compiling. >> >> All those nodes already have a label you can use: >> >> &nsp0_alert0 { >>     temperature = <105000>; >> }; >> >> &nsp1_alert0 { >>     temperature = <105000>; >> }; >> >> If the same pattern is already used for other thermal overrides in thanks for pointing other nodes also. For gpu node, will send separate patch over current series. >> hamoa-iot-evk.dts, it would be good to prepend a patch to fix those too. > > thanks for review, will update this. > >> >> Thanks, >> Stephan >