From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E8AC432C3 for ; Thu, 14 Nov 2019 08:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EB3520718 for ; Thu, 14 Nov 2019 08:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726482AbfKNIJ2 (ORCPT ); Thu, 14 Nov 2019 03:09:28 -0500 Received: from thoth.sbs.de ([192.35.17.2]:37567 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfKNIJ1 (ORCPT ); Thu, 14 Nov 2019 03:09:27 -0500 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id xAE89CZT030781 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2019 09:09:13 +0100 Received: from [167.87.46.11] ([167.87.46.11]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xAE89CH4016661; Thu, 14 Nov 2019 09:09:12 +0100 Subject: Re: [FYI PATCH 0/7] Mitigation for CVE-2018-12207 To: Dave Hansen , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Ralf Ramsauer , "Gupta, Pawan Kumar" References: <1573593697-25061-1-git-send-email-pbonzini@redhat.com> <23353382-53ea-8b20-7e30-763ef6df374c@siemens.com> From: Jan Kiszka Message-ID: Date: Thu, 14 Nov 2019 09:09:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.11.19 22:24, Dave Hansen wrote: > On 11/13/19 12:23 AM, Paolo Bonzini wrote: >> On 13/11/19 07:38, Jan Kiszka wrote: >>> When reading MCE, error code 0150h, ie. SRAR, I was wondering if that >>> couldn't simply be handled by the host. But I suppose the symptom of >>> that erratum is not "just" regular recoverable MCE, rather >>> sometimes/always an unrecoverable CPU state, despite the error code, right? >> The erratum documentation talks explicitly about hanging the system, but >> it's not clear if it's just a result of the OS mishandling the MCE, or >> something worse. So I don't know. :( Pawan, do you? > > It's "something worse". > > I built a kernel module reproducer for this a long time ago. The > symptom I observed was the whole system hanging hard, requiring me to go > hit the power button. The MCE software machinery was not involved at > all from what I could tell. Thanks for clarifying this - too bad. > > About creating a unit test, I'd be personally happy to share my > reproducer, but I built it before this issue was root-caused. There are > actually quite a few underlying variants and a good unit test would make > sure to exercise all of them. My reproducer probably only exercised a > single case. > Would be interesting to see this. Ralf and tried something quickly, but there seems to be a detail missing or wrong. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux