From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 275B0C48BE5 for ; Tue, 15 Jun 2021 17:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1132161009 for ; Tue, 15 Jun 2021 17:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231288AbhFORu5 (ORCPT ); Tue, 15 Jun 2021 13:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbhFORu4 (ORCPT ); Tue, 15 Jun 2021 13:50:56 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE14CC06175F for ; Tue, 15 Jun 2021 10:48:51 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id q15so75216ioi.4 for ; Tue, 15 Jun 2021 10:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OMBjXE0nRB8hM4ofcPKfdh+yz7lSZL32Yvdx3/K1Jlo=; b=hKxtm8WFh9YoGvi0n7W5NAiFIcqM6qTSjF8UPIf1AJdLVuS9d4lDmVdlZ2CbC3LEBh OzNJQHSrOk7cyez+SEwLHyCLXJL+2nOUoUL45k8eDRYJrmDlPzX+LSlA6AEqRjebAi/E Uw19hk04bLMxvlKlW+t9l6GIpAqjntY+JrygE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OMBjXE0nRB8hM4ofcPKfdh+yz7lSZL32Yvdx3/K1Jlo=; b=ZVbJrhwymZcczViVfwbiNv1IZcawT8aibPeNMF9IoXRkD+/CcJFJmDVqhrPxukTaf6 n18EzSD2D5eVQI8FgSWMHrMSgbEJ1jN5N4WQef2OADPRUspOWrMG50j9x1cipjHZlyh6 y/f2Ff9I6GsVojuIYHCEM7Jgs1NAoN4x/XmQnywcrQG5vj0Q17m2uwLQjyB4zYuzuqG0 A5VB61EmX5m+ghRn/jYa8KZUGVUzu7SmEQmt0oXOu5owvXa2j6gBv49mso1fBHwp9s2M aGBFjcJnQ1co0eAce+riYdnrh2VP1f1X6qVEqA55TxgZsRcKlGexMypkMxkMuIa3sD4W WYUA== X-Gm-Message-State: AOAM5322WE2+AJEwYtPtr1RR/pySzs2Vf3m9yTNv6pKvF32z3p7f+WhN UrRbd231WmTdrHsmIW5YSezjvA== X-Google-Smtp-Source: ABdhPJzRmw+gb2MPsjwBJ8v4iy5MCoEBD646f5nqJkHMdAYrFtY+hr/mpSeNhJ0hTqIQ7KCPKyuOrQ== X-Received: by 2002:a02:838c:: with SMTP id z12mr387399jag.89.1623779331309; Tue, 15 Jun 2021 10:48:51 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id e14sm9444583ile.2.2021.06.15.10.48.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jun 2021 10:48:50 -0700 (PDT) Subject: Re: [PATCH -next] usbip: tools: Convert list_for_each to entry variant To: Zou Wei , valentina.manea.m@gmail.com, shuah@kernel.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <1623740319-15988-1-git-send-email-zou_wei@huawei.com> From: Shuah Khan Message-ID: Date: Tue, 15 Jun 2021 11:48:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1623740319-15988-1-git-send-email-zou_wei@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/21 12:58 AM, Zou Wei wrote: > convert list_for_each() to list_for_each_entry() where > applicable. > > Reported-by: Hulk Robot What is the report? Please include the reports. > Signed-off-by: Zou Wei > --- > tools/usb/usbip/libsrc/usbip_host_common.c | 4 +--- > tools/usb/usbip/src/usbipd.c | 8 ++------ > 2 files changed, 3 insertions(+), 9 deletions(-) > Please explain why this change is necessary. Is it a good idea to explain what happens if you don't make this change? thanks, -- Shuah