From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <corbet@lwn.net>, <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>, <akpm@linux-foundation.org>,
<manfred@colorfullife.com>, <jwilk@jwilk.net>,
<dvyukov@google.com>, <feng.tang@intel.com>,
<sunilmut@microsoft.com>, <quentin.perret@arm.com>,
<linux@leemhuis.info>, <alex.popov@linux.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
"wangxiaogang (F)" <wangxiaogang3@huawei.com>,
"Zhoukang (A)" <zhoukang7@huawei.com>,
Mingfangsen <mingfangsen@huawei.com>, <tedheadster@gmail.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH next] softirq: enable MAX_SOFTIRQ_TIME tuning with sysctl max_softirq_time_usecs
Date: Mon, 24 Jun 2019 21:32:48 +0800 [thread overview]
Message-ID: <e870e089-efb6-53a7-4299-8468f2ba8852@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1906241141370.32342@nanos.tec.linutronix.de>
On 2019/6/24 17:45, Thomas Gleixner wrote:
> Zhiqiang,
>
> On Mon, 24 Jun 2019, Zhiqiang Liu wrote:
>> 在 2019/6/24 0:38, Thomas Gleixner 写道:
>>
>> Thanks again for your detailed advice.
>> As your said, the max_softirq_time_usecs setting without explaining the
>> relationship with CONFIG_HZ will give a false sense of controlability. And
>> the time accuracy of jiffies will result in a certain difference between the
>> max_softirq_time_usecs set value and the actual value, which is in one jiffies
>> range.
>>
>> I will add these infomation in the sysctl documentation and changelog in v2 patch.
>
> Please make the sysctl milliseconds based. That's the closest approximation
> of useful units for this. This still has the same issues as explained
> before but it's not off by 3 orders of magitude anymore.
>
> Thanks,
>
> tglx
>
Thanks for your suggestion.
I will adopt max_softirq_time_ms to replace MAX_SOFTIRQ_TIME in v2.
next prev parent reply other threads:[~2019-06-24 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 15:14 Zhiqiang Liu
2019-06-23 16:38 ` Thomas Gleixner
2019-06-24 4:01 ` Zhiqiang Liu
2019-06-24 9:45 ` Thomas Gleixner
2019-06-24 13:32 ` Zhiqiang Liu [this message]
2019-06-25 14:46 ` Zhiqiang Liu
2019-07-08 14:14 ` Thomas Gleixner
2019-07-09 1:25 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e870e089-efb6-53a7-4299-8468f2ba8852@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=feng.tang@intel.com \
--cc=jwilk@jwilk.net \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=manfred@colorfullife.com \
--cc=mcgrof@kernel.org \
--cc=mingfangsen@huawei.com \
--cc=quentin.perret@arm.com \
--cc=sunilmut@microsoft.com \
--cc=tedheadster@gmail.com \
--cc=tglx@linutronix.de \
--cc=wangxiaogang3@huawei.com \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®