From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753597AbdJNMER (ORCPT ); Sat, 14 Oct 2017 08:04:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35658 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbdJNMEO (ORCPT ); Sat, 14 Oct 2017 08:04:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9B99781DE8 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH v5 0/3] i2c: Hookup typec power-negotation to the PMIC and charger To: Andy Shevchenko , "Krogerus, Heikki" Cc: Darren Hart , Andy Shevchenko , Jarkko Nikula , Wolfram Sang , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" , linux-i2c References: <20171011094121.6108-1-hdegoede@redhat.com> From: Hans de Goede Message-ID: Date: Sat, 14 Oct 2017 14:04:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sat, 14 Oct 2017 12:04:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14-10-17 12:45, Andy Shevchenko wrote: > On Wed, Oct 11, 2017 at 12:41 PM, Hans de Goede wrote: >> Hi All, >> >> These are the last 3 patches from all my work to add support for >> USB PD charging to Intel Cherry Trail devices with a Whiskey Cove PMIC >> and fusb302 Type-C controller. >> >> With these 3 patches these devices change from slowly discharging >> at 5V 0.5A to actually charging at 12V 2A, so getting these upstream >> is important for users of these devices. >> >> Wolfram does not really have time to review the first 2 patches, so if >> someone else (from the people in the Cc) can review the first 2 patches >> and esp. the first patch, so that we can get this merged for 4.15, then >> that would be great. > > The person comes to my mind is Heikki, > Though I dunno he has time either. The first patch, although it is an i2c-core change, is really quite simple. I believe anyone can review it. But it does need someone other then me to take a proper look (and not just do a code only review) because it is a core change. Maybe there is another way to solve the problem (persistent / predictable device-names for i2c devices instantiated through board-data), but I don't think so. Also note this is all kernel internal stuff, so we can always change it later. Although it would be better to get it right in one go. Regards, Hans