From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755687AbdJJB7i (ORCPT ); Mon, 9 Oct 2017 21:59:38 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:40097 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbdJJB7g (ORCPT ); Mon, 9 Oct 2017 21:59:36 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: hjc@rock-chips.com X-FST-TO: sandy.huang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: hjc@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output interface To: Rob Herring Cc: Mark Yao , David Airlie , Mark Rutland , Heiko Stuebner , dri-devel , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" References: <1506049221-117283-1-git-send-email-hjc@rock-chips.com> <1506049229-117376-1-git-send-email-hjc@rock-chips.com> <20171003215631.rc2jsf2m3qgoltsb@rob-hp-laptop> <2d502a9d-e952-8afb-d2d7-45c21c36da7e@rock-chips.com> From: Sandy Huang Message-ID: Date: Tue, 10 Oct 2017 09:59:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2017/10/9 21:05, Rob Herring 写道: > On Mon, Oct 9, 2017 at 3:06 AM, Sandy Huang wrote: >> Hi rob, >> Thanks for your reply. >> >> 在 2017/10/4 5:56, Rob Herring 写道: >>> >>> On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote: >>>> >>>> This path add support rv1108 rgb output interface driver. >>>> >>>> Signed-off-by: Sandy Huang >>>> --- >>>> Changes in v2: >>>> 1. rename rockchip,rgb-mode to rgb-mode; >>> >>> >>> You can't just drop the vendor. This needs to be documented in a common >>> place that others will find and use. See panel-common.txt or >>> panel-dpi.txt. >>> >>> Alternatively, you could just drop it and let the panel compatible imply >>> what the mode is. >>> >>> >> ok, get it, i will move the rgb-mode to panel and describe it at >> panel-rgb.txt. the patches will be send soon later. > > Don't create yet another common panel file. We already have > panel-dpi.txt which is for digital parallel interface. > The panel-rgb.txt define different rgb output format and timing, this is the detail info: https://patchwork.kernel.org/patch/9992241/ do you think this need move to panel-dpi.txt? > Rob > > >