From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406C729B78D for ; Tue, 10 Mar 2026 13:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773150077; cv=none; b=VlGaFB4XbV9YSGfRv5KYm3mNjrkvB7KT64QwkNc0q5AX0Hxw6axBQi1u0jaWSl+d8EOWBEKLfs+jWUFUfyljkYiV/SaASjF9rAxUMuGk4VStH1+UT2Kynsqo791qd0mrEPWZk1omRRtw2TsmAiD/5vZ9ZZ8UVx7QAKPSvLhKzuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773150077; c=relaxed/simple; bh=2/lj6B8seo20eJVoikHZMdPOJJq4TtVmvM/xqVoEKIM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eZYuFS+UEtK35BW5LP0fI0x1bki+RTq4EB8iXVXilstLg276EOJswSOg3Jueulvt3Ci2of8LJhod/qGPM5BGoRtpaewjqvjLaQxhxuPN0vyqTu485NbLnv1xV53ryveD/MmZwcox9UmPxOpSMUjWy2gqMqohOMhai2pE1Xzg2bI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KgsIsnZ6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FE676n9/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KgsIsnZ6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FE676n9/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaifX3417778 for ; Tue, 10 Mar 2026 13:41:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2/lj6B8seo20eJVoikHZMdPOJJq4TtVmvM/xqVoEKIM=; b=KgsIsnZ66wvp0i7h yMm/6WZCQ0gtSgzSPf0D/FHx+giZn3kulbmrM2QKK7AoXq3dD7qb8+G+LqLHJZEn WQi6moMDMvf/jdJjGeqOx6U9gfOSvYJKgrMDLNGwW4fHpqG8oueIjUzv/XxFk/kU o8ZvD5sl+7vwpC7S/ByfzCQteKZzoTqayZpjzRb6hnKbABI6wLWXPSbVNZ5xCOam 2eVSpxsTKd1TLuLtn9Mofe1jgYsnYv8HwnTt/z1Rjb/ldqL4mM9PAwdGV3ugoxbM JQQzSkzOLJLxTTi5288IjMayl2AdL6GQ+mP+LSz+aT6ERKV5gQQhCXEQ4b6mI2YL VjBO1w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctja28ge5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 13:41:15 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd8e89d19bso114691685a.2 for ; Tue, 10 Mar 2026 06:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773150074; x=1773754874; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2/lj6B8seo20eJVoikHZMdPOJJq4TtVmvM/xqVoEKIM=; b=FE676n9/TvsfUbQJD4ZMpgUgD/69i8TGLo5havLv+Mu4/qEWb+9gH4TBjLlWJcz8wP eFkYCTp28eWMhye2u8ePl4s/OU+4Pqs7rpaN7E/71e8PPi2lnP84Ciiy0lv6XCR701lq KDsExXirXF8tcNLxkdA6jregMiuTcai5cn/Wx7xwGyOAeiDbf6WpG30GR0fGlHGG8wbK rCcpr/ionZM7D3LrbUiJAa/rX568hUQSHmmUHbZZkBo/npJFqjjw4N0sy8UJj0Ar6+iC JRBRPa0bI/woMg+Tet0O7pVQq4fODGBRUlsBvMkPw0Qg1B7q3cPySaqx5CCOfIACVCLR gBmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773150074; x=1773754874; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2/lj6B8seo20eJVoikHZMdPOJJq4TtVmvM/xqVoEKIM=; b=qlKlmmx6/etq23A1h5wO69P1xPDJu+v+MX4mbznULDjwdzDqkHkOQMW64GqS0Sp13u 2y+wIF6FmtvHJeSQfD5kYQOXHYLkF/MyVv3BO9VxsChfZdrUY54uKPDgoJ69WFTSQQnX Iu2o4UVnpkKjTTB45+KnJ8qzz45J+bTgxhFejyCNa56q/GJp1yUa/08crJOChwU79b+C /vqmaLQG1vUhs3wWheO9M3fTeigA9xCs5BMpY6VaIVOJF8T/NEazXz4UcomU/OOmcrab Qr7dIMkykQAFgBdx3w7njNSPLlV9FaCNL9Gyoc90+mYPyE2fX+TviNCU3Lo412igrmWr rk5A== X-Forwarded-Encrypted: i=1; AJvYcCXN1g/9ytCpy7Ia8DbMyhsziChU+FmQ76+K8RlmyY79HahaJFMsgpYi7jXwSpmgQq3ClbKlS/Aus7sgU1k=@vger.kernel.org X-Gm-Message-State: AOJu0YxhA76hvwMidwFi2U5mVasFxMbQ+F4SGHiMRFO/K0YkDXcHWDhp iFZeLdGNUoMTxYcpoLgrO43dxKrwmvB4PSEYM7EttdnYlIU25nQQfJJiZrRF2hoTpG+mFx4PCRB aeVkSXjmlcfX3I/TbQqHJxMM6sSh/a2fRFDGZSQ+TinQ0p1du4KxQSEvmpx9dFVN6zjn+Euxu4j M= X-Gm-Gg: ATEYQzy3ElahrkFLdp1u8P+qW0riU/5zA+qmFTz+PwWwrIIwDmlBuHng6ahGEDQTS/6 v6B958RQCA3FyOIgH/mopkP3uw9tWf51hwzB4DXx4n2PHtvCAZTSegdLjN5e5rQcl686vFCBpA3 cQ7iX6gbig/XUs7d0JsgqwTTZ1JZf4VaBASrxzg2HRYA6j/eq+53Y6Zszc/tcqaq8euUKBw9Xda JMfDwxbLoWU7Fon63TZBRkVaZVa19jTg20xPpeddRq8v0OwjfZJEkSpI5njip0aNo0cEGaf1PD0 HFMQN3GrvjVBQYSVfVE8espEI62EV+WeKs0KcfFWW+NgLT9mkuLMDZ5o2y1VArpBZZzcYgGPMlv 53QPPdPY5Ws+ATB5X+jRRVvz3JN52nntQla7DHFTXaQDVtMYlzdJ/ILNIJ44uw6TK4z8eOXmGwH y3ils= X-Received: by 2002:a05:620a:25d0:b0:8cb:3fa7:c4f0 with SMTP id af79cd13be357-8cd6d42bc36mr1494496985a.5.1773150074484; Tue, 10 Mar 2026 06:41:14 -0700 (PDT) X-Received: by 2002:a05:620a:25d0:b0:8cb:3fa7:c4f0 with SMTP id af79cd13be357-8cd6d42bc36mr1494492485a.5.1773150074051; Tue, 10 Mar 2026 06:41:14 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b94351894bfsm468701766b.1.2026.03.10.06.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 06:41:13 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 14:41:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] arm64: dts: qcom: msm8917-xiaomi-riva: Commonize for Redmi 4A and GO To: barnabas.czeman@mainlining.org Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, phone-devel@vger.kernel.org References: <20260305-riva-common-v1-0-436f1f4b7399@mainlining.org> <20260305-riva-common-v1-1-436f1f4b7399@mainlining.org> <2255b753-4d40-4e49-a89c-22ee939c51d1@oss.qualcomm.com> <6665244d82ee8776826a7f6a4e64af99@mainlining.org> <70ad0b19dbeee89c04c17a0618a9cecc@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <70ad0b19dbeee89c04c17a0618a9cecc@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=c9WmgB9l c=1 sm=1 tr=0 ts=69b01f7b cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=OuZLqq7tAAAA:8 a=fr_QDkp6JkS4JuZzObsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-ORIG-GUID: EHktO8Fp9YXJjxxMHbZjgC_yknpW1rA6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDExOSBTYWx0ZWRfX/XISZ+SfapV6 PWn71jrUT4I+rV4Zb/YSDPi4LXVk4wX5M9yfs7fsMz/WD2W3Ueo0qHr4d8yySNxKtcOb+5Awu4B zVDpk7P/q2F2iodm7HBxdK3C02RrEm3E1oitT3Ui78WWv/Lyf1va0TS0OrajgSE1BXmg6LotdzY QW40W1TUssW+CXkQ8UjMzhR3u2XH4cTFFmLfeq4T+SxfzP4o4w5bJ1WB3lY5cyDgbjDF48OSVZP 49W7xw4q5/rBpzQQ2ZyF2DNRoDzn6zp0nfRHQ4+7yxCqAxU5tc4L0iqA+rol9eQxXQaD81e7tab MIxlWO+ZMYoBbt/WkSe9iu2BWQB16wtezbL6fItMZCnGG7ggl/r7Jjk1xXRwizuQBMUPrjN+zHV nJ47WD+Ow3+YWj84eoMqOTuWlyxcv62HiZoWsT4ytkE1DgcEAIF8735DzQUSqNldsm9mQMfogsk ovcR41ZMh+dyixG7FGQ== X-Proofpoint-GUID: EHktO8Fp9YXJjxxMHbZjgC_yknpW1rA6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100119 On 3/10/26 2:26 PM, barnabas.czeman@mainlining.org wrote: > On 2026-03-10 14:21, Konrad Dybcio wrote: >> On 3/10/26 2:11 PM, barnabas.czeman@mainlining.org wrote: >>> On 2026-03-10 14:04, Konrad Dybcio wrote: >>>> On 3/10/26 1:57 PM, barnabas.czeman@mainlining.org wrote: >>>>> On 2026-03-09 13:55, Konrad Dybcio wrote: >>>>>> On 3/5/26 6:28 PM, Barnabás Czémán wrote: >>>>>>> Redmi 5A is very similar for Redmi 4A (rolex) and Redmi GO (tiare), >>>>>>> it can be commonized for avoid unnecessary code duplications. >>>>>>> >>>>>>> Signed-off-by: Barnabás Czémán >>>>>>> --- >>>>>> >>>>>> Could you please try adding the following to your gitconfig: >>>>>> >>>>>> [diff] >>>>>>         renameLimit = 999999 >>>>>>         algorithm = histogram # or 'copies' >>>>>>         renames = copies >>>>>> >>>>>> and see if this generates a shorter diff? >>>>>> >>>>>> Konrad >>>>> One more question should i rename msm8917-xiaomi-riva-common to msm8917-wingtech-common, >>>>> they are wingtech devices. Which naming is preferred? >>>> >>>> I think xiaomi-riva is easier for people to associate with a phone >>>> they may have in their drawer than wingtech-s88503 >>> What about renaming just the common part to msm8917-wingtech-common? >> >> I think it adds more confusion without much benefit. Probably none >> of these devices have been released without a Mi logo on the back. > Yes but riva codename is related to Redmi 5A and naming as msm8917-xiaomi-common > could cause confusion later when i would send Redmi Note 5A (ugglite) what is > none wingtech device and have much more difference. Well, you never mentioned that! perhaps msm8917-xiaomi-wingtech.dtsi then? Konrad