From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2AFA37A48D for ; Wed, 14 Jan 2026 08:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768380315; cv=none; b=k58NXV7Oj8zuUU6UmN5HqaWk3yK6yvgIDG7bUeqyKGykYFFcmIEk5iBMEoNSs5ivaDI03MhLdhPgyS81BBHJ/YsVMDb+BQ43AEiQRSqFMWqS6uh+PUeKi/BygAokFTcFlRBhfpf5ByJcH1NAmHddXv611Two7I8/n2QuDXraDvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768380315; c=relaxed/simple; bh=eJcQDDz6REmSWrTBdqEWlgdintf4zRq+JCXkCNub2Y8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=NwMXI1gsBtmc3NyszuSevnoDeXdFCxI8st9QDB46JJYP5zSLj5Q1XDfe/ZDXYS10uHDjwKLabeSev6AXATCrnHP+L003HZuwmBbzoIy56lS9rkyoYClVgu+hdIP+xaOl9VGYfIVE0K99KPAd46zQcgnU7NC7jh4fXADKT4yBVbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GnICHjVK; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GnICHjVK" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47ee301a06aso5657845e9.0 for ; Wed, 14 Jan 2026 00:45:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768380308; x=1768985108; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Nn2P+cTkVwAykWlPC24DGRgRkCJONiMX3KadIJciMfk=; b=GnICHjVKxFYjvprT0kxIuSwl3/NK/Gk1erlRhqu8FjkAtxD1X4Es1Sfy7zL+cBZTCC 1CpCPqExcw40U/qgSsW21C0plll8CFyNR9YpMDkEq+hlgVG3FPFl5E9mf4Xtoh+ty6BI trD0GXKw9Mv37jCIXJCzn1usq3YRS3MomQYdG/kZXDt+sozxLDCzvv6OXpGZyqBVH51y 5TADgAtS+GWtbUetot309vPb+jNqZj+9VsEYlHyZVi9t+hmvVfv0wyOcKGS0BRLyZFQ5 NutRavjLc8FMEPX3ZqgPXDepaNBYJlDSfjHtGMxnHN8A4bUiKLltH6tyPFrrvO6lzItF MXvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768380308; x=1768985108; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nn2P+cTkVwAykWlPC24DGRgRkCJONiMX3KadIJciMfk=; b=Q/1PfVcOCn3A6vGjSVt1a999W3kYx6Y5d/QjYvoVOg6ZKhbXPi6VaKxsOppgMUzldU NypPzZoOlp6iORlrfEWBvQTMgK2PhHVoq8aBE4XxUSH3SBdwaUJJj06+ENJSV+XANmaB 5aETrPiRrpBktE8dGPaluDFIdeQ4s3/7yEiUqOSjVjUygdxROWl2Me6Tt6SY8p/VSan+ UvDnI23Ug0uqZQ/h3qzdu3czNPDIV6DmerZGnZaWORApeT7aqloTHT4cxByaMq09XLr9 qpFI7i+YN9h0n06IFHs147DiRXm+8eZkwBsfFFLNDQv/WZaH0+DHtKr4KKVIDrwDUntZ POhg== X-Forwarded-Encrypted: i=1; AJvYcCW0k0ZDIZwH0aVPkKgJdArnXQemm+p0yepWCYrn2iPaVgdyR2guWmCmWeJRGd6B/qFMgAVp04bPVtctH4s=@vger.kernel.org X-Gm-Message-State: AOJu0YwNWnE3yeO2mrGgg4rdrDO+ZuOVAMpNgJUxR1Ou2LjNNDuAb8Rg i9+pnW/JsFa1KDv2bggpWbWx7XJkvRqJjUIWQgOv8sqz41wovUJa26aDBoZKprA3XMg= X-Gm-Gg: AY/fxX6LQVj6HVPIkifUDuCB53SpAcZSj6ncq8fW/jJJPLvRXzH0LeDbZTuvZ3KFCnY a6DE3mr6+wiTT5ZwGGG14OFf8tD5eFtL/ZC+J/Jb4Qf7nP9/vJ1ydv29WlyUB53xV4i7St/0Znc T+ceSIcOZqCiU59Ota1BN5PCf4tkGFCET+3vkQTeM9334OItVsFs/0p480ZQ/1BycB7Pk785Hlw DlWoY0G7+RZWp09ACK/5VU2Elf79E3VO8UUu3XlM++hlRC0eUUxYXZkgKFn9z7uRkh8XVFa0ttq OiZ8fsUw8nqFnzLb9UxRsHy527m7GBo1PBHRx6yvx/L3PNVvMYg9vbgt29IWZhgqzkn62xg4FmL 185m2nLKKyTSMK8n4G5y/6lDLbnj44mInxx6Zd/WigMbePPSeoWR8jUtozzULlnrMaIArtic0O+ 9FLrDPUg2jtWZRDl7XaCCdLJ4aIXk75l+S1zRVcxKdD2HH93fpRRAJTOCLNi7P6WY= X-Received: by 2002:a05:600c:870b:b0:477:7b72:bf9a with SMTP id 5b1f17b1804b1-47ee338a737mr19695785e9.28.1768380307818; Wed, 14 Jan 2026 00:45:07 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:b357:7e03:65d5:1450? ([2a01:e0a:3d9:2080:b357:7e03:65d5:1450]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee57a2613sm16475575e9.6.2026.01.14.00.45.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 00:45:07 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 09:45:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC RFT] drm/msm: adreno: attach the GMU device to a driver To: Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter References: <20251022-topic-adreno-attach-gmu-to-driver-v1-1-999037f7c83e@linaro.org> <3149158c-a6c4-4c5d-9011-de4db8d1220c@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <3149158c-a6c4-4c5d-9011-de4db8d1220c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 1/14/26 07:37, Akhil P Oommen wrote: > On 10/22/2025 6:14 PM, Neil Armstrong wrote: >> Due to the sync_state is enabled by default in pmdomain & CCF since v6.17, >> the GCC and GPUCC sync_state would stay pending, leaving the resources in >> full performance: >> gcc-x1e80100 100000.clock-controller: sync_state() pending due to 3d6a000.gmu >> gpucc-x1e80100 3d90000.clock-controller: sync_state() pending due to 3d6a000.gmu >> >> In order to fix this state and allow the GMU to be properly >> probed, let's add a proper driver for the GMU and add it to >> the MSM driver components. >> >> Only the proper GMU has been tested since I don't have >> access to hardware with a GMU wrapper. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 354 ++++++++++++++--------------- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 - >> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 3 - >> drivers/gpu/drm/msm/adreno/adreno_device.c | 4 + >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 + >> drivers/gpu/drm/msm/msm_drv.c | 16 +- >> 6 files changed, 192 insertions(+), 195 deletions(-) >> > > Niel, > > Could you please send the follow up revision of this patch? Lets get > this fix merged. I'm really struggling on the separate_gpu_kms part, it's not trivial at all. I'll try again and report my current status. Neil > > -Akhil. >