mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Henry Martin <bsdhenrymartin@gmail.com>, linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH] HID: uclogic: Add NULL check in uclogic_input_configured
Date: Mon, 31 Mar 2025 19:06:36 +0200	[thread overview]
Message-ID: <e87f2369-204f-431f-b434-bff4b8e78742@web.de> (raw)
In-Reply-To: <20250331113732.10722-1-bsdhenrymartin@gmail.com>

…
> Add NULL check in uclogic_input_configured, to handle kernel NULL
> pointer dereference error.

Do you complete the error/exception handling also with the statement “return -ENOMEM;”?


By the way:
I suggest to simplify the handling of the condition “suffix”
with if/else branches a bit.

Regards,
Markus

      reply	other threads:[~2025-03-31 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 11:37 Henry Martin
2025-03-31 17:06 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e87f2369-204f-431f-b434-bff4b8e78742@web.de \
    --to=markus.elfring@web.de \
    --cc=bentiss@kernel.org \
    --cc=bsdhenrymartin@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®