From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE93E377AAF for ; Mon, 3 Aug 2026 10:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785752935; cv=none; b=ntnmiGeCEvmKFSq/czaFoHtu321dzbTPY9IQ/7sjoyfPt62InIR0EAL/ZQu53YrtzAYg582/oOzKIE0bYgO3WihYhfk+g8dZknssI9Tn21tekk0gPGALdb+mVFg62wVZepw4ANH+xmsMXwLuCgbIr/Bkj++VnS3UQBsjQHdVyY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785752935; c=relaxed/simple; bh=YI+SeCXwe3QTLmdnaISpUAOdff3psaCPzk+4QqEjGC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eLg7dEJcJoOmy9mhdc5KNyd/mXKNUmAwjXI+lu0c9XeQhuh1FSVtEuBVTw3qbA07qvwvLb001KvCM7SPKGqqsE2PoSN8wPQbQxbvgC7Ef3hy9fnuZUE6oZhZiPhBoPJQUZhY90pMBJXYFC6jT1mKTp6i2fyqDTyRQzhBsRyIedQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MwiN0Mx5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qha4TP7k; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MwiN0Mx5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qha4TP7k" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6736S0kM051604 for ; Mon, 3 Aug 2026 10:28:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Awud7FmFVBbftdi8mV4xuz2E3JQyxCXhFkWyr+GNJ38=; b=MwiN0Mx5BKR/F6I4 uqweJyOgADhPfHdriE3f9k5zS0JqcnsKy5R7j0+DUv6J8MwOJHO4OdgpONGuIidx IDAOGm3rxSyZBnNAZRIf+xMC+Z9++C2ejecIY53uwEo1dN0Fv9vLRcLK7tNcI9Lo z+KrSrhi6t43ppImzdh1TKgn6KX2EiwplpVcSoJTe0heLAz9AiXdPNosg/yUCEtf 5wjgoCLo/7B30v7PIjWBHoWe1PEtarUI0OubhmAWW613doe96uD0wUwShV95IF22 OROQ5UakQuQSUwj4VPK+YBYz5dTZQ/dwvKuUAMU2jhqFuhz/EE0Oe2Pd1HLBgo9e QPZhOg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnrb91gw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 10:28:52 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so5492790a12.3 for ; Mon, 03 Aug 2026 03:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785752931; x=1786357731; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Awud7FmFVBbftdi8mV4xuz2E3JQyxCXhFkWyr+GNJ38=; b=Qha4TP7k0HQ+QAMPFKft5zxzoU9pePk8WMQ/Cgb48mK+MNfzQw+GsZluWpUuEFZTFF kRIL3alZnsv/U68uex2o7MHtosvDp1JT918Y4hlLrm91VyXc+IB/HNpWk8WpOWwmY7fE ywvIFnqwT35iAQ92SH4tTpVZPWgQxx5dtRFmQca7w2qCBGfRg7Edg0FGp7cKTWpTtdAv 6i3zWbObfDPKDsDINc/E4HMGS4w5KtuK4NP1jySUU25oTXuMuHMAmgLBT4yU1mHQRxt+ Y+DhEDaIaDgbf1ni4wFadx9jaoVOO8rs7c28HrlcVkDjiyBBfTOzM2xXqZK5N1/MLMCS cWCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785752931; x=1786357731; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Awud7FmFVBbftdi8mV4xuz2E3JQyxCXhFkWyr+GNJ38=; b=aHF0/n1TEcUscCPXkXdsU69o/eBzda4d8/6qOPgbnb4lR2pJvyh/l9b/2Vs8jKDZvK AWEplJGDwOUk3qfQrK1+/QWolV3Aik9LgUUtPgR1CehyZMqYAorQUGtG1vdMyXsk/NR2 XSvu/mNalVvxctH0Ohrj6fHxU9FObqk+yBk/sviKezbSApkzkggwFD+kk9qQB9d0s25p NjdXIR92RBcqkqUP+pANK58YQ9tgHosV78KPBXzbyw/+8okSpZESsTsmXHRS1u97zXBH eDCJrSd11rBSiRHscvrVyZ0SmchK9I2z0sZqbdB5BsGasvh84Qrr18Z5W5+gGf1/zLfG oosg== X-Forwarded-Encrypted: i=1; AHgh+RoKP96NnCZisSjdwMOVgVaYXGY5v6lSdgzp2thVPZH1QhFtrP9CK2aFfp1WMrUx4FPERcsk/g4JGKZZpbs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0VhUNvOsGy+4GwdNhpb5OsUeXELDWvvqxqTWKu0mXbcfymSPI 3nqyG/H+CKSa9DYo/RgWAt33FWZ4g3ETPo23dE91wgakQugBM++TTc++re/OnmqMuQdnCi+5NIR qt6b7byslNRjgz9aj2Gf3WvxbwoMHXxUZCGEsuS9hpxzL7j9kuFZ35U1CPsMqGtR2+Jw= X-Gm-Gg: AR+sD10pdiKHRArq0tgOUWd+YTQM580cm3mNmwBNLufWN01/xeav+yvPdXsG72CLCGi 66gQQwIRnLunqb8LI6nGCnUp9/rjBkzPNNdGEjqXnl4sc0/x7GefLPAboqF7tpIWk/PE71Gm5s0 kWsxSEA+Do7/Jolm/OOYHj5S7bcVCEm+LcJn229Mm/3G95rMJD3POgCxmp1kUNVQn/5ozwhbXrJ gKW+c6zymS5mE3thEJFxZ71fWLC0d7AWziZci6kCchOnO+++DGorxr/OuLSHd3yszkjbSNg5zQP vikiWLfx9YMvc3U4bRrcZGsYpTMophsD5Jz3OZsAlnjbjxyD+sRdycxDpIp3fURUL1vFhmyPQsg 8+0hWLwtJzsjvInIejtNpuyRz9B1+ X-Received: by 2002:a05:6a21:a03:b0:3c3:8bab:80b with SMTP id adf61e73a8af0-3c92a8be67amr9529964637.61.1785752931544; Mon, 03 Aug 2026 03:28:51 -0700 (PDT) X-Received: by 2002:a05:6a21:a03:b0:3c3:8bab:80b with SMTP id adf61e73a8af0-3c92a8be67amr9529932637.61.1785752931082; Mon, 03 Aug 2026 03:28:51 -0700 (PDT) Received: from [10.218.15.172] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e29a126sm39291548eec.31.2026.08.03.03.28.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 03:28:50 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 15:58:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] dt-bindings: interrupt-controller: mpm: Document power-domains property To: Marc Zyngier , Marek Szyprowski Cc: Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Shawn Guo , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260713-b4-shikra_lpm_addition-v1-0-3d858df2cbbf@oss.qualcomm.com> <20260713-b4-shikra_lpm_addition-v1-1-3d858df2cbbf@oss.qualcomm.com> <87ik6i6i22.wl-maz@kernel.org> <3dac25b9-a464-4350-aff5-0ada4dc1d65e@samsung.com> <86cxwoocol.wl-maz@kernel.org> Content-Language: en-US From: Sneh Mankad In-Reply-To: <86cxwoocol.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDA5MyBTYWx0ZWRfXyz43Iu+VbvPz 8e8BW+nfxmuD46AQjzZdCBS1I1dU8zXwdm6O4dCUVnz28a+TzI8tICtCW7/w/3SxKeMv8P0jvo6 Luileg/ya4rztGg00km6uSvnx1iRf4c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDA5MyBTYWx0ZWRfX9Rc4uLDKKsUd rsErvQhMn9Iv+o/He8SOODi5TazakHIeKfEBQ9IOteW1lijPI717l0+ekGMM23xW3edf2mVxj24 Q4yKiC3p202JDco5rMX4e5syPweTi8z9CcS4I7ws+PRcDkKsNgV5KeQTkKgAoXgDZ/tP44YbOoY RpX8N6J90mLV6na0JX/FG9K4t5KXNKxQHqL8mK7EBLcGDmcKrePZVb9fq3VGVR8ppjbtfe55gml LC2N1PFCwm4X0aN0GluJnqlizNvZ3U5HLTO616QaP55v6cD8p6IAxxln6HffI6MQV2wrt0LsZbu mHrl2EaSIFZNajQfFtz7BMM+5S4IdbqRlQgGuezLg0iFro1VrJZ1Q+yOjqsbjO6K79ENARFsAqp kcwY0IVnOKXEC/tLYu7GCaAnZCz159avPGf78kGURa9c1tWgexrKhhUNIQwl4A6uQAg2/bnSc0d I33ZN1a9YIy++blEANg== X-Authority-Analysis: v=2.4 cv=RNSD2Yi+ c=1 sm=1 tr=0 ts=6a706d64 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=Hgul2LAUnyHK3LffZBEA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: BqH-uvKjBp_FCY9R7KocWh-Hm-e239RX X-Proofpoint-ORIG-GUID: BqH-uvKjBp_FCY9R7KocWh-Hm-e239RX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030093 On 15-Jul-26 2:24 PM, Marc Zyngier wrote: > On Wed, 15 Jul 2026 07:38:59 +0100, > Marek Szyprowski wrote: >> >> On 13.07.2026 17:11, Marc Zyngier wrote: >>> On Mon, 13 Jul 2026 11:25:41 +0100, >>> Sneh Mankad wrote: >>>> Remove #power-domain-cells property and add power-domains property for >>>> MPM device. >>>> >>>> Signed-off-by: Sneh Mankad >>>> --- >>>> .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >>>> index ebb40c48950ab3a8fc86f5708acfc33c33d68993..3f9645fbc3c20633077aaa589e5d5a43928dab51 100644 >>>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >>>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >>>> @@ -68,8 +68,8 @@ properties: >>>> - description: MPM pin number >>>> - description: GIC SPI number for the MPM pin >>>> >>>> - '#power-domain-cells': >>>> - const: 0 >>>> + power-domains: >>>> + maxItems: 1 >>> What makes you think it is OK to change an existing binding in an >>> incompatible way? >> >> >> Ulf suggests that this has been modeled upside down in the initial >> submission: >> >> https://lore.kernel.org/all/CAPx+jO9d1qH12mxg-n1rkbp6Xd__sdrSMeoc7CPELE+jgxRYHA@mail.gmail.com/ > > Sure. We have collectively fucked up a lot of bindings over the years, > mostly because of the lack of accurate documentation and people not > giving a damn about the correctness of these descriptions. I'm glad > that Ulf is now able to make it right. > > But that is not a license to invalidate DTs retrospectively. We don't > update DTs in lockstep with the kernel (I *never* do), and something > that existed must be supported in the long run. > > Properties can be deprecated, but: > > - they must be kept in the binding > > - drivers must still honor them if they are present in the DT Currently only two chipsets have #power-domain-cells property mentioned in MPM DT node, agatti and sm6375. Agatti - does not execute CPU cluster LPMs as of now, so not handling the #power-domain-cells in driver will have no effect in functionality. sm6375 - Being an old chipset I am not aware of its status. If the driver honors the #power-domain-cells property, even the CPU level idle states will fail to probe on these devices, due to the reasoning provided in cover letter. With these patches, the CPU level idle states will function properly, so will cluster level idle states if enabled. In addition to that, the fallback mechanism of registering for CPU PM notification when power-domains property is not mentioned in DT node will take care of the RPM notification when cluster idle state is entered. As suggested by Konrad, I will add a brief explanation on the need for this bindings change in this patch. Thanks, Sneh