From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756006AbdGKRLE (ORCPT ); Tue, 11 Jul 2017 13:11:04 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9740 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755613AbdGKRLC (ORCPT ); Tue, 11 Jul 2017 13:11:02 -0400 Subject: Re: [PATCH] scsi: hisi_sas: make several const arrays static To: Colin King , "James E . J . Bottomley" , "Martin K . Petersen" , References: <20170711121144.15840-1-colin.king@canonical.com> CC: , , Linuxarm From: John Garry Message-ID: Date: Tue, 11 Jul 2017 18:10:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170711121144.15840-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.93.105] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.59650690.007D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fa6a870ec77a449996ddf500691727a9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 13:11, Colin King wrote: > From: Colin Ian King > > Don't populate various tables on the stack but make them static const. > Makes the object code smaller by over 280 bytes: > > Before: > text data bss dec hex filename > 39887 5080 64 45031 afe7 hisi_sas_v2_hw.o > > After: > text data bss dec hex filename > 39318 5368 64 44750 aece hisi_sas_v2_hw.o > > Signed-off-by: Colin Ian King > --- Acked-by: John Garry