From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932619AbeCECj1 (ORCPT ); Sun, 4 Mar 2018 21:39:27 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53598 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932417AbeCECj0 (ORCPT ); Sun, 4 Mar 2018 21:39:26 -0500 Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer To: Jesper Dangaard Brouer Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, john.fastabend@gmail.com References: <1519982954-14360-1-git-send-email-jasowang@redhat.com> <20180302170758.332600d6@redhat.com> From: Jason Wang Message-ID: Date: Mon, 5 Mar 2018 10:39:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180302170758.332600d6@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote: > On Fri, 2 Mar 2018 17:29:14 +0800 > Jason Wang wrote: > >> XDP_REDIRECT support for mergeable buffer was removed since commit >> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() >> case"). This is because we don't reserve enough tailroom for struct >> skb_shared_info which breaks XDP assumption. So this patch fixes this >> by reserving enough tailroom and using fixed size of rx buffer. >> >> Signed-off-by: Jason Wang >> --- >> Changes from V1: >> - do not add duplicated tracepoint when redirection fails > Acked-by: Jesper Dangaard Brouer > > I gave it a quick spin on my testlab, and cpumap seems to > work/not-crash now (if I managed to turn back config to > receive_mergeable() correctly ;-)). > Thanks for the testing and reviewing.