From: Yuesong Li <liyuesong@vivo.com>
To: Thomas Gleixner <tglx@linutronix.de>,
anna-maria@linutronix.de, frederic@kernel.org
Cc: linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] kernel:time:hrtimer: Use helper function hrtimer_is_queued()
Date: Fri, 30 Aug 2024 10:53:18 +0800 [thread overview]
Message-ID: <e891a5cf-613d-4d7e-b146-798f60777a63@vivo.com> (raw)
In-Reply-To: <874j739x57.ffs@tglx>
On 2024/8/29 23:17, Thomas Gleixner wrote:
> On Wed, Aug 21 2024 at 17:46, Yuesong Li wrote:
>
> Please add a proper subsystem prefix to the subject.
> git log --oneline $FILE
> gives you a decent hint
I will send a v2 if you agree with my reason.
>> The helper function hrtimer_is_queued() checks whether the timer is
>> on one of the queues. Replace the raw check.
> Why? What's the benefit of this change?
Compare to raw check ,I think this makes the text more readable.
>
> Thanks,
>
> tglx
Best Regards,
Yuesong
prev parent reply other threads:[~2024-08-30 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 9:46 Yuesong Li
2024-08-29 15:17 ` Thomas Gleixner
2024-08-30 2:53 ` Yuesong Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e891a5cf-613d-4d7e-b146-798f60777a63@vivo.com \
--to=liyuesong@vivo.com \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®