From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A8EC43461 for ; Fri, 7 May 2021 07:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46F07613D6 for ; Fri, 7 May 2021 07:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235078AbhEGHIo (ORCPT ); Fri, 7 May 2021 03:08:44 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:48531 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233730AbhEGHIm (ORCPT ); Fri, 7 May 2021 03:08:42 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id EDB0F58124E; Fri, 7 May 2021 03:07:42 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Fri, 07 May 2021 03:07:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=q+VAC568GzCcDMwNCnFEDtF1412nCnb auFVwJbsbwuM=; b=WXyJPMT4ZWdAIyCkoeAsXwq6dmXIAnL5Lagij8d9NaJasTp gMEmdzxHWb5kxAsNbRM9HZfddh6ttG/sYDs25cvmWO/DXtPFO71WpRWV4+TKnSyK 8prGrbS6mOX2+RGbXZLRGcY1W5IvZrvBvVJqgSSWqAGz+EkMVQHmkjDuWejNUAeI S6zaf4Eul7CQReOrFj8pH8og2xJ94egkn/O8UlP7YgnYiPZypwUgGjZrPa44F2kI A2yRR1/ZyI6bAeWbNiwlg+DpD71rUWY1eBgBwFSN59Mib/gtqRBlw9Jra5e+jJOz AE/o3AOF1t4f/8Zd7ga/cFPJX8sBenpmOpV/alg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=q+VAC5 68GzCcDMwNCnFEDtF1412nCnbauFVwJbsbwuM=; b=cl9pdSrnMTdDTAhtRs2BaO N9iFPUJjIFO6QorSloXzuKZjTCF0hRy5y107XXN6gOTYanFVn17535Wmeh5nquEJ jnfO5P9I7Xm/IrDMmscjRNCMYL4n00cHPbjtF7OrT7S9vN3zERiVAQtAreYOtShC 7l+PXGTBbBe+ZaRBs3Fo+ge+UUgoA9YsUsglS0X+/LoiXPFm87j4AwGoAZi8NjK1 6LNY82X9i9dH8j3oEbmIVFB8gggDUuYSSN7EU2QvDOW4pgryfGe8+I13LrR1gTHo VAIhHB8/yhOlZ+RVR/Aqw/1i8jYbEPceUmBpX2TX2mFAxE5rScClOqKlEUGDFftA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeguddguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtf frrghtthgvrhhnpedutddtkeeugeegvddttdeukeeiuddtgfeuuddtfeeiueetfeeileet tedvtdfhieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id D246BA00079; Fri, 7 May 2021 03:07:40 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416 Mime-Version: 1.0 Message-Id: In-Reply-To: <20210507065918.GE23749@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-5-steven_lee@aspeedtech.com> <20210507065918.GE23749@aspeedtech.com> Date: Fri, 07 May 2021 16:37:19 +0930 From: "Andrew Jeffery" To: "Steven Lee" Cc: "Ulf Hansson" , "Rob Herring" , "Joel Stanley" , "Adrian Hunter" , "Philipp Zabel" , "Ryan Chen" , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" , "Hongwei Zhang" , "Ryan Chen" , "Chin-Ting Kuo" Subject: =?UTF-8?Q?Re:_[PATCH_v3_4/5]_mmc:_sdhci-of-aspeed:_Add_a_helper_for_upda?= =?UTF-8?Q?ting_capability_register.?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 May 2021, at 16:29, Steven Lee wrote: > The 05/07/2021 10:13, Andrew Jeffery wrote: > > > +/* > > > + * The function sets the mirror register for updating > > > + * capbilities of the current slot. > > > + * > > > + * slot | capability | caps_reg | mirror_reg > > > + * -----|-------------|----------|------------ > > > + * 0 | CAP1_1_8V | SDIO140 | SDIO10 > > > + * 0 | CAP2_SDR104 | SDIO144 | SDIO14 > > > + * 1 | CAP1_1_8V | SDIO240 | SDIO20 > > > + * 1 | CAP2_SDR104 | SDIO244 | SDIO24 > > > > It would be nice to align the columns to improve readability. > > > > Columns seems are aligned in my mail client(mutt) and my editor(vim). > I paste the above comment in Notepad++, columns are aligned as well. > Ah, it's probably my mail client then. Sorry for the noise! Andrew