From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967045AbcJZMj6 (ORCPT ); Wed, 26 Oct 2016 08:39:58 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35956 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966669AbcJZMjw (ORCPT ); Wed, 26 Oct 2016 08:39:52 -0400 Subject: Re: [PATCH v2] ARM: davinci: da8xx: Fix some redefined symbol warnings To: Sekhar Nori , gregkh@linuxfoundation.org, khilman@baylibre.com References: <1477397492-7925-1-git-send-email-abailon@baylibre.com> <1477397492-7925-2-git-send-email-abailon@baylibre.com> <3dc1c2c2-c4c5-07d0-3d3e-b8d917adda81@ti.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Alexandre Bailon Message-ID: Date: Wed, 26 Oct 2016 14:39:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3dc1c2c2-c4c5-07d0-3d3e-b8d917adda81@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2016 01:57 PM, Sekhar Nori wrote: > On Tuesday 25 October 2016 05:41 PM, Alexandre Bailon wrote: >> Some macro for DA8xx CFGCHIP are defined in usb-davinci.h, >> but da8xx-cfgchip.h intend to replace them. >> The usb-da8xx.c is using both headers, causing redefined symbol warnings. >> Remove the macro and update the da830-evm board file to use da8xx-cfgchip.h >> >> Signed-off-by: Alexandre Bailon > > This leads to build error on v4.9-rc2: Oops! Sorry for that. I will fit it. > > arch/arm/mach-davinci/board-da830-evm.c: In function 'da830_evm_usb_init': > arch/arm/mach-davinci/board-da830-evm.c:120:15: error: 'CFGCHIP2_REFFREQ' undeclared (first use in this function) > cfgchip2 &= ~CFGCHIP2_REFFREQ; > > Thanks, > Sekhar >