From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B73A3F9F22 for ; Thu, 9 Jul 2026 11:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783595896; cv=none; b=oArI4Ki6/gatdY0TGPWE4Lmmf/DOXDpwmHcfXbiqHoJC6uKV0D2+obbt0JTE9bHH0Faxak0XQmVxomRurr0QGauB5sUnBbjDCLY5B3ErGBgZcIPrFpcbehL1H+IrjNDl1jlAxPUj76YHYUY5oMAoxk5zSLZDlFL3ElZg/jhWzzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783595896; c=relaxed/simple; bh=JIbY68pv3tLScCT8hJ5wD/twH9VZZ6GeM09XMVAWRO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n/7CHcy/BH9nKioTlZIz3gb4q//THWrcyrlQ85bTFDAKxPVqL7OYVyUT1pmM0JBuDHMgUo9mf7nMZmn0y90+0aKLTjy4WnkSOOIV1AwioRMcJX8DcRLycYa47g8yI5tJzrTJ0Uks9ZYrPr6ySTOydctCiiIMS03Eyxl7+WP7uaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fyY0pNu1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a/HUYHsJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fyY0pNu1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a/HUYHsJ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669Axivq1614738 for ; Thu, 9 Jul 2026 11:18:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vihb0TqYNakYFNkvFgdqTcLu+5oolASwgMBC4TOzm2s=; b=fyY0pNu1SYakkEnc jiua1Bz59Z/HxTO6ZZj7/6VoWVtUtY1ICmo9H1Pd2QjrZWC8gJfOm9T5qkA9XEc9 zZ/LvhTR9YL1D4FRKeeUPeBJzIH2ig7MkQc5n0wn0ncq5EOUUpyCj9xucWrHafNA Mhaf5VX3wvgWTqgyvze8xNYS1i224SoOljNif2MkoC4501PXlkZEU2tlj13tOCVF k1OcXw5rO9V9U6F4nqjFTDFlr4SsHrosvOnlojjBDdlvWI+//0MRkxof7+sUSdLM DMKQPcPOu2w9XU1PRa+80kn2vAWE27oY8QNhmoRslamfrHh0e5dTRzAtOzXXQfwX yQEHaQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9ug6kdv1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 11:18:13 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51a87ef9713so8502001cf.1 for ; Thu, 09 Jul 2026 04:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783595889; x=1784200689; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vihb0TqYNakYFNkvFgdqTcLu+5oolASwgMBC4TOzm2s=; b=a/HUYHsJbOFVJwiRG0RQW3NNKqU/49xLeQWT+/4XZQfImsPMD5gE4TyA500tJAQbh5 lSVhkRGTSMHeFp7jrrELc/EBVaP+vqpvtGCr+IbQUI03ePqJpd3O3TG2L+r2wdu1xxJZ 7bSiKGtmqWVBZovpbQaJnslJQIy3uPwn5zokQuJ8IXdMplF8QkRk3HeGebnUP+spIa3V wvUPRi9IV3PQTixkgnnWVLlM63x7Fx4O1H0JEBDz0sr3std8kiQkO+Qx8dRBK95XsXdK cgPRYwdQx9ZDNnPa5Owp0HwVPhtfgEYCNPMaVzMUaNFixzVfVv3vcN0iA+QS19sqnA6P B6DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783595889; x=1784200689; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vihb0TqYNakYFNkvFgdqTcLu+5oolASwgMBC4TOzm2s=; b=FGWsg/um1YLmF+Mlj0awC2I7ZbTQwolpk0kmg78KkkW2aA3OOSIxKRZPaVAMWCQ66E tp9CLO1zg6SsUkVBCN7vzNZKyFSa4K0yivDaHYAZ+d0hKa4OQhyi9aXqbFXVLfU9XREw CyvKU5perV6Hh0q18ne/q1MDSP0jZB+xLMmNWdXTbtSZZQoCDDjmbxDcAyyiSLUzZDFp WMwCKaT8+oiQvyimU/0SwbT+8bh4hAfre9diPS16/VeOZH/p7kJ9XgqQj6m9Uth+xO8V hoW2xdJBDfHeXnW6H0iZfHu12JwVR9uAi5yuZwBdOkSM8IEnJH4b5Z0qyPdvMR/0QVXB 1+YA== X-Forwarded-Encrypted: i=1; AHgh+RrSz8PBM7dFqnWg8i7gF+mO/EKldyw5UrIsckYxVImyZoG86KzIAKV8c/qAl5ihPF5+r7a6RJt3fDbyGQc=@vger.kernel.org X-Gm-Message-State: AOJu0YwKwz36aKbueMYQYFy6vFHnXtV95D3fsVoc+/sHeI+0zc8a3mhs XtvXnFNJsIcbQaySHuUWyKImpnfv4eX8Hx2tOSZnUe1UTjuqcUeEdf2OPrYS2Zj/4R1FCi0iNu+ cibs/at9nTmrcBD4rj1ZogkEi/cGREGL/7bKEBQh1D2Imn2VQp1enEZJMNxcGAR1bDbY= X-Gm-Gg: AfdE7ckeUF1rQMl32kvowZ5WtHSzQvXEOjMJTFZrQOToMJ9e4DO2km2qDyUlVYMAdYN bb8hjX1gAQkxnRpqMO0JcTYJ7OKu7RQS41iDxgDc1jBcPvdf5JOYqBINgTN7zsSt5WivsuM/eoo c3/WrVhNAoA6VwyAtoodu3k7nJf6AiZnx5vUS8B39RWIQJxrhzLQ5x51L6PRvbA8YDvNHwkQXOU l5LePSQItBXT3BZDWDEp4HNQBqaH53REf7lz6iaVB0EhTwfTfPkVJscMfei3343njoGPY5xDd6x 1Lvn8GRJmPsZ8Fy9Z0en7rrq10RnWfTXF0kloHidx18kG66RNJhh71jEH6iuOU77LUVaD8CGj+4 P3mgYwMPA0CrXSljd4GCSxqojvOhVJkUeptHwF9VebGOWRHrOv17tDmbgOxKGHw== X-Received: by 2002:ac8:5d06:0:b0:51c:98f:f282 with SMTP id d75a77b69052e-51c9b9c9812mr22454251cf.27.1783595888707; Thu, 09 Jul 2026 04:18:08 -0700 (PDT) X-Received: by 2002:ac8:5d06:0:b0:51c:98f:f282 with SMTP id d75a77b69052e-51c9b9c9812mr22453591cf.27.1783595888214; Thu, 09 Jul 2026 04:18:08 -0700 (PDT) Received: from [192.168.69.219] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6d53absm53036115e9.6.2026.07.09.04.18.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 04:18:07 -0700 (PDT) Message-ID: Date: Thu, 9 Jul 2026 13:18:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch 08/18] x86/syscall: Use [syscall_]enter_from_user_mode_randomize_stack() Content-Language: en-US To: Thomas Gleixner , LKML Cc: Peter Zijlstra , x86@kernel.org, Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, =?UTF-8?Q?Michal_Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org References: <20260707181957.433213175@kernel.org> <20260707190254.079478122@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20260707190254.079478122@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDEwOCBTYWx0ZWRfXzJNFWqZysLWa YeRTx8WIzMAmyPi6zGibpHkGuzvAUuHRdTUMrQqT+kOQqV1Rnv7ano2ydDue51AoSrVl3eXCLhj ODdflKeMb8jCkN6NiHD1XV8YxixVv+s= X-Proofpoint-GUID: bCKt-ytwXyKObYagLPD9btYuzSuhUKDV X-Authority-Analysis: v=2.4 cv=cL3QdFeN c=1 sm=1 tr=0 ts=6a4f8375 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=wOAZ5We2mjvvK_q5lLMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: bCKt-ytwXyKObYagLPD9btYuzSuhUKDV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDEwOCBTYWx0ZWRfX8HH3OIqeXHam NaELamcYqQwe8/WO/DVtDFLUqhjSS340FCGBTkEjWf5KUKp/B8jSd0zyWfvhj0nwWgD0zPfaD4d GHML0NUkfAsTye8xsqU8nuV+i8XE8bHosIpHJWFgbPdGLi61g9+aIf7bdtqMaMlf1f1hsX+EZiG NjWnF1gJM7J7+RkEtH0noyRU+SHsIOSlXyaP8lZzqnEn7vrBEP1XM4po89UyubaC6RfsIjGYBh/ fZwOTKFlaZQrD5Ym8kszzpHkn1ghbjPCsL/3DqFyUAGSnV1Hok55R5gkGawKDv71XaCPV8PhVkI DPJ9E7tfDzkHSFejtS13ffr3z4VD+ZXs4QUG1LT5ZxuIMUFO1kZc+C4yh/yiF72IIrwoXE/UWPz MSSr1LfXhWzf6Qa3Q5gAa7H66RBC8tt6R5cBQj27FvuaCVl1Lyi1NJd/lkuzgav5odQhcMVT6SL 6NAbmiSjFt4Fzl9bCfw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_02,2026-07-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090108 On 7/7/26 21:06, Thomas Gleixner wrote: > These functions integrate the stack randomization. > > syscall_enter_from_user_mode_randomize_stack() has the advantage that the > randomization happens early right after enter_from_user_mode(). > > In both cases also the overhead of get/put_cpu_var() in > add_random_kstack_offset() is avoided. > > No functional change. > > Signed-off-by: Thomas Gleixner > Cc: x86@kernel.org > --- > arch/x86/entry/syscall_32.c | 19 +++++-------------- > arch/x86/entry/syscall_64.c | 3 +-- > arch/x86/include/asm/entry-common.h | 1 - > 3 files changed, 6 insertions(+), 17 deletions(-) Reviewed-by: Philippe Mathieu-Daudé