From: Jason Yan <yanaijie@huawei.com>
To: John Garry <john.garry@huawei.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <intel-linux-scu@intel.com>,
<artur.paszkiewicz@intel.com>, <jinpu.wang@profitbricks.com>,
<lindar_liu@usish.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hare@suse.de>
Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander()
Date: Thu, 6 Jun 2019 09:34:56 +0800 [thread overview]
Message-ID: <e8ad370e-6528-2ab1-5001-ab3fa4dc5ae8@huawei.com> (raw)
In-Reply-To: <1559751143-168560-1-git-send-email-john.garry@huawei.com>
On 2019/6/6 0:12, John Garry wrote:
> Many times in libsas, and in LLDDs which use libsas, the check for an
> expander device is re-implemented or open coded.
>
> Use dev_is_expander() instead. We rename this from
> sas_dev_type_is_expander() to not spill so many lines in referencing.
>
> Signed-off-by: John Garry<john.garry@huawei.com>
Cannot agree more，
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2019-06-06 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 16:12 John Garry
2019-06-06 1:34 ` Jason Yan [this message]
2019-06-06 11:57 ` Jinpu Wang
2019-06-06 22:02 ` Martin K. Petersen
2019-06-07 13:26 ` Martin K. Petersen
2019-06-07 13:29 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ad370e-6528-2ab1-5001-ab3fa4dc5ae8@huawei.com \
--to=yanaijie@huawei.com \
--cc=artur.paszkiewicz@intel.com \
--cc=hare@suse.de \
--cc=intel-linux-scu@intel.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@profitbricks.com \
--cc=john.garry@huawei.com \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®