From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E55CC77B6F for ; Tue, 11 Apr 2023 10:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbjDKKGl (ORCPT ); Tue, 11 Apr 2023 06:06:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbjDKKGc (ORCPT ); Tue, 11 Apr 2023 06:06:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24E4F40CE for ; Tue, 11 Apr 2023 03:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681207520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MQJyPgI1aYYzA2uRs3ijvvK+cnKO4iZfEOcreRoPXjs=; b=czn+tzH7I/B1eadPWMH/CboFqqxIJhCnv7Jy3eW2ym2D95zqPFtwRmUvD8UC2foZ9VpKcW BMOtu2niX8AxNBYJL+tRdqESaSCM2J/uYcdrz9hIP3eSXAndPpmGKY06X95uVkWg4CxaIH +g/AhDH4NyeOhMwhVjPmtuqJnkU1qaY= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-vqBNGZaHNZit8Fsoxhi3rQ-1; Tue, 11 Apr 2023 06:05:11 -0400 X-MC-Unique: vqBNGZaHNZit8Fsoxhi3rQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-5e965c54827so5467976d6.0 for ; Tue, 11 Apr 2023 03:05:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681207511; x=1683799511; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MQJyPgI1aYYzA2uRs3ijvvK+cnKO4iZfEOcreRoPXjs=; b=MkrXlLjNv5RQsrQzH880RWOHob7uqbRVQ5GeZEwBkQZIm7iRvzkWmt6Xzw8s7j4Be4 Sl5x7FfW3tkDFvj0flwQaLv731nwsHJZnLlP485vMwxMlBQJ4g5fNK8kRDF/HZiKMaYJ wsmLUdLVzEXznshMB4Ib7SY+HSVml39VJmBfYlPFhmuJad4l3uLe2XL8qc9vXeTa79gX Y10KhIJR6gAUs3fKL15kt4aL1PzIRz8sP/yAHEc3AFQaHt/srRA1qrfw5UhOco8lOdil j78oAwvnrznwFnvErYB3XhkmiHvKw5BnEg1NNp5JCfcj7DBLWnuwXDcdmnW4gq6RalAX pfjQ== X-Gm-Message-State: AAQBX9fUaqLatKWtsNQ68yFTcKqOzELYmqU4y9f3dbVNzo3KhOrdEHzm p5v6wkRmG6kLDmxwpN/d+8cfMjHuq7rjq7QRpP9Vjl5gyumCGjmISPjhuLZZxU679dAS261oIT8 hV4RRtvonfUjmDnjrWd5bKUQh X-Received: by 2002:a05:6214:c2f:b0:5e0:84a9:2927 with SMTP id a15-20020a0562140c2f00b005e084a92927mr21797618qvd.4.1681207510951; Tue, 11 Apr 2023 03:05:10 -0700 (PDT) X-Google-Smtp-Source: AKy350YmLFiGBKxZDQs5rlvP04KZi2wea8aPk/MtNoc+mqDg0UQ3dbzvIp555xXOrBZYvyYg8te9XA== X-Received: by 2002:a05:6214:c2f:b0:5e0:84a9:2927 with SMTP id a15-20020a0562140c2f00b005e084a92927mr21797594qvd.4.1681207510694; Tue, 11 Apr 2023 03:05:10 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-239-96.dyn.eolo.it. [146.241.239.96]) by smtp.gmail.com with ESMTPSA id y7-20020a0ce807000000b005e96ebf9bbdsm2443728qvn.5.2023.04.11.03.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 03:05:10 -0700 (PDT) Message-ID: Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: add remove callback From: Paolo Abeni To: "Radu Pirea (OSS)" , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Tue, 11 Apr 2023 12:05:07 +0200 In-Reply-To: <20230406095904.75456-1-radu-nicolae.pirea@oss.nxp.com> References: <20230406095904.75456-1-radu-nicolae.pirea@oss.nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2023-04-06 at 12:59 +0300, Radu Pirea (OSS) wrote: > Unregister PTP clock when the driver is removed. > Purge the RX and TX skb queues. >=20 > Fixes: 514def5dd339 ("phy: nxp-c45-tja11xx: add timestamping support") > CC: stable@vger.kernel.org # 5.15+ > Signed-off-by: Radu Pirea (OSS) Andrew: my understanding is that a connected phy, maintains a reference to the relevant driver via phydev->mdio.dev.driver->owner, and such reference is dropped by phy_disconnect() via phy_detach(). So remove can invoked only after phy_disconnect Does the above sounds reasonable/answer your question? Thanks Paolo