From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F5A3BC692 for ; Mon, 30 Mar 2026 10:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774867048; cv=none; b=dnwOm2S4qmffRHuWs1kcvCKN1YgLhYMo+3FGL29El8l0HSR+H90Meln9UcpiMqk+IUWtkYLSADeSdbcOt2oqjL6N7F6C8PvWKPgLQidwQp55//KgvoN2b7gba/TI9DFTwvKCAR1MvXstV4+faEWU62tnN79fIf/lrSfZVx2BX8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774867048; c=relaxed/simple; bh=A0rwi342NA0thVWkYLC9pM8mbYKOGJmT+ZWmM0pml7E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gPNYYmVidmnCr4kNI7dl7V6khxWN4I0VKYSpf0RzA/9ZD7nS61CCZDx2wXToI0g8ajflR4zDZ0hZM8JJBd5tjGvlycxbrb3aKfsAh+zIGnpGUfOqArZXeYovqVSsnKJS6xw/WifFnriQZNw0hBng8KH0EasDNNz/9vworvcKoaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=a5EQvbiZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=CBKTkUGD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=a5EQvbiZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=CBKTkUGD; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="a5EQvbiZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="CBKTkUGD"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="a5EQvbiZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="CBKTkUGD" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 674FB4D1F1; Mon, 30 Mar 2026 10:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774867045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+PvFINlm0q8uC458q0kngZxQAI9x8UUOiDVxzmXaJE=; b=a5EQvbiZJ7eX9Fr5qrzYVNZ0zxLLH+71q2znxv/CQgaE1O387VaAeVtT0XyaMN1muwbJfD qEQ05tVpy1GhGO4WG07vF7Y2mPRjamVa/dWApepljfqiQKz4Z4dmrgKlZ3PAw3ZqHdt8JA mPKsod8tE1a8YtHGaVMB4dR/FMplGsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774867045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+PvFINlm0q8uC458q0kngZxQAI9x8UUOiDVxzmXaJE=; b=CBKTkUGD5Zw0BMjGMoRreK+6UnQjlwEEmRM9odmC2Aj31pjgg0NeWlEdUgds+BkTVESObM me6ukMm5pXec6CAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a5EQvbiZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CBKTkUGD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774867045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+PvFINlm0q8uC458q0kngZxQAI9x8UUOiDVxzmXaJE=; b=a5EQvbiZJ7eX9Fr5qrzYVNZ0zxLLH+71q2znxv/CQgaE1O387VaAeVtT0XyaMN1muwbJfD qEQ05tVpy1GhGO4WG07vF7Y2mPRjamVa/dWApepljfqiQKz4Z4dmrgKlZ3PAw3ZqHdt8JA mPKsod8tE1a8YtHGaVMB4dR/FMplGsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774867045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+PvFINlm0q8uC458q0kngZxQAI9x8UUOiDVxzmXaJE=; b=CBKTkUGD5Zw0BMjGMoRreK+6UnQjlwEEmRM9odmC2Aj31pjgg0NeWlEdUgds+BkTVESObM me6ukMm5pXec6CAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 208304A0A2; Mon, 30 Mar 2026 10:37:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OL2EB2VSymleaQAAD6G6ig (envelope-from ); Mon, 30 Mar 2026 10:37:25 +0000 Message-ID: Date: Mon, 30 Mar 2026 12:37:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/15] nvmet: Rapid Path Failure Recovery set controller identify fields To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260328004518.1729186-1-mkhalfella@purestorage.com> <20260328004518.1729186-2-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260328004518.1729186-2-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[purestorage.com,broadcom.com,gmail.com,nvidia.com,kernel.dk,kernel.org,grimberg.me]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: 674FB4D1F1 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: On 3/28/26 01:43, Mohamed Khalfella wrote: > TP8028 Rapid Path Failure Recovery defined new fields in controller > identify response. The newly defined fields are: > > - CIU (Controller Instance UNIQUIFIER): is an 8bit non-zero value that > is assigned a random value when controller is first created. The value > is expected to be incremented when RDY bit in CSTS register is asserted > - CIRN (Controller Instance Random Number): is 64bit random value that > gets generated when controller is created. CIRN is regenerated everytime > RDY bit is CSTS register is asserted. > - CCRL (Cross-Controller Reset Limit) is an 8bit value that defines the > maximum number of in-progress controller reset operations. CCRL is > hardcoded to 4 as recommended by TP8028. > > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/target/admin-cmd.c | 5 +++++ > drivers/nvme/target/core.c | 9 +++++++++ > drivers/nvme/target/nvmet.h | 2 ++ > include/linux/nvme.h | 10 ++++++++-- > 4 files changed, 24 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich