From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbeCZSsw (ORCPT ); Mon, 26 Mar 2018 14:48:52 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:42050 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626AbeCZSsu (ORCPT ); Mon, 26 Mar 2018 14:48:50 -0400 Subject: Re: [PATCH 2/3] Ktest: use dodie for critical falures To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, dhaval.giani@oracle.com References: <1513380011-15274-1-git-send-email-tianyang.chen@oracle.com> <1513380011-15274-3-git-send-email-tianyang.chen@oracle.com> <20180321111608.31c712a2@gandalf.local.home> From: Tim Tianyang Chen Organization: Oracle Corporation Message-ID: Date: Mon, 26 Mar 2018 11:48:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180321111608.31c712a2@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8844 signatures=668695 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=490 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803260185 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the review Steve! One quick comment inline: On 03/21/2018 08:16 AM, Steven Rostedt wrote: > On Fri, 15 Dec 2017 15:20:10 -0800 > Tim Tianyang Chen wrote: > >> Users should get emails when the script dies because of a critical failure. Critical >> failures are defined as any errors that could abnormally terminate the script. >> >> In order to add email support, this patch converts all die() to dodie() except: >> * when '-v' is used as an option to get the version of the script. >> * in Sig-Int handeler because it's not a fatal error to cancel the script. >> * errors happen during parsing config > I would say you don't need it for parsing the config either. It doesn't > make sense, as you wouldn't have the mailto defined yet. > Maybe it's the way I worded it. This patch coverts all die() to dodie() _except_ these situations. So it doesn't send emails on config errors, which is what you said here. >> @@ -4132,7 +4132,7 @@ if ($#ARGV == 0) { >> if (! -f $ktest_config) { >> $newconfig = 1; >> get_test_case; >> - open(OUT, ">$ktest_config") or die "Can not create $ktest_config"; >> + open(OUT, ">$ktest_config") or dodie "Can not create $ktest_config"; > Here, no config was specified, and so no configs either. > > >> print OUT << "EOF" >> # Generated by ktest.pl >> # >> @@ -4167,7 +4167,7 @@ if (defined($opt{"LOG_FILE"})) { >> my @new_configs = keys %entered_configs; >> if ($#new_configs >= 0) { >> print "\nAppending entered in configs to $ktest_config\n"; >> - open(OUT, ">>$ktest_config") or die "Can not append to $ktest_config"; >> + open(OUT, ">>$ktest_config") or dodie "Can not append to $ktest_config"; > Here too. Right, I missed these two. I will send out v3 shortly. Tim