From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754611AbcGVSJa (ORCPT ); Fri, 22 Jul 2016 14:09:30 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35564 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbcGVSJ2 (ORCPT ); Fri, 22 Jul 2016 14:09:28 -0400 Subject: Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF To: Randy Dunlap , "linux-next@vger.kernel.org" References: Cc: Ray Jui , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Linus Walleij , linux-gpio@vger.kernel.org, LKML From: Ray Jui Message-ID: Date: Fri, 22 Jul 2016 11:09:19 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 7/22/2016 11:06 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled > but COMPILE_TEST is enabled by making the driver depend on OF. > > ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function) > .dt_node_to_map = pinconf_generic_dt_node_to_map_group, > > Signed-off-by: Randy Dunlap > Cc: Ray Jui > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > --- > drivers/pinctrl/bcm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig > +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig > @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO > config PINCTRL_CYGNUS_MUX > bool "Broadcom Cygnus IOMUX driver" > depends on (ARCH_BCM_CYGNUS || COMPILE_TEST) > + depends on OF > select PINMUX > select GENERIC_PINCONF > default ARCH_BCM_CYGNUS > Thanks, but a fix was already submitted by Arnd and picked up by Linus: https://lkml.org/lkml/2016/7/15/649 Ray