From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA6D34D3BE for ; Fri, 29 May 2026 01:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780017086; cv=none; b=UCTpcfGm/5LBZBm7vXDndDD2t+EQbbaTqTNR4C2Pihii28QyLqjcjpZ5S5X90Ws96eiFjzs0jQiwdMc/2nMHyAUkOxFQ8vlkvIUg7evVtxbNlJ9uxI66Inms/tVd02YmsX0WW7CA7THWl+XLQzuHxlo2Xp8pP7M5UG3E3pIp/E8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780017086; c=relaxed/simple; bh=mcHo8JfFEIPdyBUH3cQiAKFGy1GHwOjxXVO4i593kUI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZPt/i7njxN9RwL8JeRtOT1MdgjUMOPwZO3kchQ1684+50Vp9A6tDf/cuqywGb1ah2djCOfDWpu1jgwWt4vzNWL2vcedOe818b4b3x1VrDkIokGVtNn6G2yOzJ/Tb9LNK9zaHvroUXoeTmhXkWsY9MA9dYgCxyYtIJ1Dzpjhkyeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nbEAfdBX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BRMpTHEW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nbEAfdBX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BRMpTHEW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64SKkvQ81932335 for ; Fri, 29 May 2026 01:11:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J4shBszuHUw9GWZJYtSKssHaaKnXl5RvEARP037Y9X8=; b=nbEAfdBXG+a1G0FU Yv66BJRaGRfwkX7Cvltzx1hWJl9lfmQn+jrPCw2oSSd7mxv5BGeoVclalPz+l4Ds yIcQgUD6/YaZdEl9mIJsC8UwGjg45MKGrabLzQ/j3SXVAJQ0s4RnupRLnyimi6ac ZTdBPaqmri/3+udDLFBGkeufaKuxTiEr/h2nzx9YhQL9OHynt2Wwbf/IdoXzCBVk vTQ9h9Pil4hVNbd09cDYEYYlDGfVCFMukCGVaNVcCJe4W3Jszr9XdcIdsNMgYx/H wMDXtmD8L1QtTcxXB7yPeR/IkROZRNZSNDKjmyMH9W0IlCZmVxm8fS32/sjaTOSo 1408Tg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eesxa9wma-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 29 May 2026 01:11:24 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8386367b23cso9614446b3a.3 for ; Thu, 28 May 2026 18:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780017084; x=1780621884; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J4shBszuHUw9GWZJYtSKssHaaKnXl5RvEARP037Y9X8=; b=BRMpTHEWlG9CGt3J2yrQoO0iCcF7y+2U2aeIEp+jgEiyhkaX9OuTNSSlUMYyiy81ZP ECRP/eaTPOB7tSVaTLTS2fcIGXFkFDvPTIdbjNTdwMn64useNOLW/oITtlwejIM1voC3 r12AK9RRHDpsSTgARfTk5Xa9S0w1GNPwvfS45jFNR1JAtenySHZhLw9m8otUz0lpdUmJ 3/mOPykx1xsfpYJQsGB3nEctY7y1W+Rzpl9W35vvCcxRmRvex5YxsMBJSXCg9zZT2ucp 7z7XqVkMaOUGhsehGZL6rQ2FJwbjXNKhb18ehOiot3Ko+YpxWgEb4mRO71TTvRl9z2km BO+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780017084; x=1780621884; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J4shBszuHUw9GWZJYtSKssHaaKnXl5RvEARP037Y9X8=; b=D8m7Je2LrF7kKDRtCJe2sdcMSGXV598D3bzzeoitp3Iu1lOI+54aiJaEuEcrlC0uhP T/oymox/qyz1qIFjMHsHl4wUM5sAE77OUZlHJyB8OTqvPSniGP9SvY/6rgWHNE5NE6cu 5lXy1ySkouHrasyBJa+NKNkrqqjMY1GeUhIpQx+V4T9wteFWuJN71O3Cec3xeSr1oMmw l34RKWNyxq9+ZrVF246CgwVryj6na6R4eWeNIpCQE5p9QvwWCDkBL3U2lhqRptYCzepl kr9Lnj6EzwkxaF1oOo/igmcv+q9JnZCJsTIqHBk2zsd20mo7sxcCLG5kUHKGXrAzHrVP k7Mg== X-Forwarded-Encrypted: i=1; AFNElJ+TRYDK5sNGR0r0ecKRugJlt92GYRxn4pfPVUmbijCq9QdfBP9eVSFU4p9wxbbG9UTHMndBmFaULAxJACk=@vger.kernel.org X-Gm-Message-State: AOJu0YxrSAZIL/oSBypIhbbFm3hIz9v0sei1jidFD7idHoQJmcNj5mIh wRJ2n+27G4BCIoCxqhPEUM1+p5cCWomk+uW5/rng/UKebRrMMPzohMJMYsghvtmH8IF9Efe8fy2 DRvRRQJIezrcgfOV4bpv+wpKX29gAyICz0lfRa4BTSFhpdPe6Igx5Z3wpWMmGdn4zgNQ= X-Gm-Gg: Acq92OHW9+pd8RFEOeJdvluDl96cQt7nBVrKqvNoraxB6f9yv4bWBkz6yLQJFuU1rlk +ZX/90Balmn3E9WjUp2dwpbzS+T4NpVuGagLXFImkBZkZIuhpwMnJSMcDrziyu8fI31gKRhED19 wBIcd0XAbaBAp4z7Z6jaEYmhtff4ih3qRzyKoJOoNg8h+cu3AFQr8h/PTffp3bExeG8SuNm4ic+ 58ODXjA5jYrK66Tj/sABsOIZUHpVL/ttc+Tuw3XLdtizF6ZXMVg7VErq7FUuoRQeBFR3pJl5pEg sg6JANcJl47+qK32bkWyvhsr2KXEP4yRNxAFqqAmWqrss2cxE4jE0UxuaeDXWgBTniyn2CzPtRj Znulx53T/CQLCvSmCKOrinnCMKNXSk43qhnGXejN5x0XfQnwBbIWSacxbQ791HAUlGENOm7Nw19 JQgpMDDLc/ZUWpnp3hzxKnIw== X-Received: by 2002:a05:6a00:39a5:b0:841:dcb5:e6f2 with SMTP id d2e1a72fcca58-84212ce3e93mr602241b3a.23.1780017083949; Thu, 28 May 2026 18:11:23 -0700 (PDT) X-Received: by 2002:a05:6a00:39a5:b0:841:dcb5:e6f2 with SMTP id d2e1a72fcca58-84212ce3e93mr602201b3a.23.1780017083408; Thu, 28 May 2026 18:11:23 -0700 (PDT) Received: from [10.133.33.247] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84214cc3575sm23322b3a.47.2026.05.28.18.11.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2026 18:11:23 -0700 (PDT) Message-ID: Date: Fri, 29 May 2026 09:11:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] scsi: ufs: core: Add support for static TX Equalization settings To: Bart Van Assche , beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , Ram Kumar Dwivedi , Nitin Rawat , open list References: <20260528100614.3386423-1-can.guo@oss.qualcomm.com> <20260528100614.3386423-3-can.guo@oss.qualcomm.com> <312d0eca-108f-48af-a1b9-a5dcc24e70fd@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <312d0eca-108f-48af-a1b9-a5dcc24e70fd@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3Zmt0ZZC6KIliMgguTTTAKF9w1r-h9je X-Proofpoint-ORIG-GUID: 3Zmt0ZZC6KIliMgguTTTAKF9w1r-h9je X-Authority-Analysis: v=2.4 cv=ZdIt8MVA c=1 sm=1 tr=0 ts=6a18e7bc cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=io7CIJzrRBQDuDm3A98A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI5MDAwOSBTYWx0ZWRfX2wlvMKFxeAgf edUuKs7nQYgvVpZnzb6jAnROD1XTd6kyLedoYn2yYNwYwghNg+ScFO0qHtToljmb9eM3ojbqIOk zgyI+9HMHyh2mkW0eyy6Isv0gq1LOWyniyoBepc9zDAPyBQ839hp0WnmYnYzM2k2Oe7L1gLqluY BaYeqsbZLOvavLWuH6Nd4ZhkU8j9ZGvvTqvNURiEbOQOcLBIqR0k05+lhC8U1nwrx4CbW/HG+pq XKx7B10M6syECB/hX2bz3b8LYXLfLMrpUCTQHGvBhBwnrPWo0O9hjkhmAgwOhsTwa7KAnxEolZm DLmolNx5lQHI9L0ZtCs6qxwn11CCJ2tU7d3IKJnpdQUjH28sGM3oidc46wlOCY2NnwZ3fIia4Le NjSbDiWIMp5w8twmcRAPjEQz8SnRTq9VU75Piw+L3E5sLAMKlDUohSiGYbcQvAqu7tIyy1TGjsU 7KEI7ukptPec9QW4xRA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605290009 On 5/29/2026 12:02 AM, Bart Van Assche wrote: > On 5/28/26 3:06 AM, Can Guo wrote: >> +static void ufshcd_parse_static_tx_eq_settings(struct ufs_hba *hba) >> +{ >> +    size_t sz = hba->lanes_per_direction * 2; > > Please mark constants with "const". Additionally, is "sz" a good name > for this variable? The code below compares "count" and "sz". I haven't > seen it before that a count and a size are compared with each other. > > Why "size_t" as data type? u32 should be sufficient, isn't it? > >> +    u32 lpd = hba->lanes_per_direction; > > Is this another constant? > >> +    if (!lpd || lpd > UFS_MAX_LANES) >> +        return; > > Should a kernel warning perhaps be issued if lpd > UFS_MAX_LANES? > >> +    for (gear = UFS_HS_G1; gear <= UFS_HS_GEAR_MAX; gear++) { >> +        snprintf(prop_name, MAX_PROP_SIZE, "txeq-preshoot-g%d", gear); >> +        count = of_property_count_u32_elems(dev->of_node, prop_name); >> +        if (count <= 0) >> +            continue; > > The body of this for-loop is long. Please consider moving the body of > this for-loop into a new function to reduce the indentation level of > the code. > >> +        for (i = 0; i < count; i++) { >> +            if (preshoot[i] >= TX_HS_NUM_PRESHOOT) { >> +                dev_err(dev, "An invalid TX EQ PreShoot (%d) >> provided in %s property\n", >> +                    preshoot[i], prop_name); >> +                break; >> +            } >> +        } >> + >> +        if (i != count) >> +            continue; > > The traditional way in the Linux kernel for breaking out of a nested > loop is using a "goto" or "return" statement. Hi Bart, Thanks for the review, I will address them in next version. Can Guo. > > Thanks, > > Bart.