From: Vladimir Zapolskiy <vz@mleia.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] regulator: plug of_node leak in regulator_register()'s error path
Date: Tue, 11 Aug 2020 09:15:07 +0300 [thread overview]
Message-ID: <e8caa9cd-f3e2-8a33-12f4-81dfd6f9c551@mleia.com> (raw)
In-Reply-To: <f106ae5b37612b36cb817691fb690e5456aea0ee.1597107682.git.mirq-linux@rere.qmqm.pl>
Hi Michał,
On 8/11/20 4:07 AM, Michał Mirosław wrote:
> By calling device_initialize() earlier and noting that kfree(NULL) is
> ok, we can save a bit of code in error handling and plug of_node leak.
> Fixed commit already did part of the work.
>
> Cc: stable@vger.kernel.org
> Fixes: 9177514ce349 ("regulator: fix memory leak on error path of regulator_register()")
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
thank you for the patch!
I was worried about a potentially remaining of_node reference leak,
but I was not able to reproduce it on practice without code fuzzing.
The change looks valid and it's a nice simplification.
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2020-08-11 6:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 1:07 [PATCH 0/7] regulator: fix deadlock vs memory reclaim Michał Mirosław
2020-08-11 1:07 ` [PATCH 1/7] regulator: push allocation in regulator_init_coupling() outside of lock Michał Mirosław
2020-08-11 15:59 ` Dmitry Osipenko
2020-08-11 16:27 ` Dmitry Osipenko
2020-08-11 17:20 ` Michał Mirosław
2020-08-11 21:02 ` Dmitry Osipenko
2020-08-11 1:07 ` [PATCH 2/7] regulator: push allocation in regulator_ena_gpio_request() out " Michał Mirosław
2020-08-11 1:07 ` [PATCH 3/7] regulator: push allocations in create_regulator() outside " Michał Mirosław
2020-08-11 1:07 ` [PATCH 4/7] regulator: push allocation in set_consumer_device_supply() out " Michał Mirosław
2020-08-11 5:23 ` kernel test robot
2020-08-11 17:28 ` Michał Mirosław
2020-08-11 1:07 ` [PATCH 5/7] regulator: plug of_node leak in regulator_register()'s error path Michał Mirosław
2020-08-11 6:15 ` Vladimir Zapolskiy [this message]
2020-08-11 1:07 ` [PATCH 6/7] regulator: cleanup regulator_ena_gpio_free() Michał Mirosław
2020-08-11 1:07 ` [PATCH 7/7] regulator: remove superfluous lock in regulator_resolve_coupling() Michał Mirosław
2020-08-11 15:56 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8caa9cd-f3e2-8a33-12f4-81dfd6f9c551@mleia.com \
--to=vz@mleia.com \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®