From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB9DD364933 for ; Thu, 18 Jun 2026 09:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774547; cv=none; b=bN/hqQ1dtVH9lW410UO14lDXa0ewb2E7UcwhV6facvna3HYKvVeP7YXvh4+qaFjXLxkrppGSt8x77SnVRmeGJgONPo3tvdFCP1W//GICcmx892pOAfmnvGOkzaE1pjxzRgJNIKuBwxAXFDUGMAHO3u5+gqfYyeBbvwBM+ZE+NV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774547; c=relaxed/simple; bh=3DmURfmH9AtJOZGA5mvvycSPMWXyC2JxOKLJnWr29W4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=D9NmigJsFdojFT53Pculgr/GWuXGW8PZheC4F774yQfHhLrolfBN51ZgObH6Xpjc3sosvMOsVMxYg2a65YxO+v+bNrRi2G7yMhnqvB++XjHjGtaqHrK852x3EOO8FComPhLkjHiUWwwS62B/xFhzlOu/XFzTgyrpLDtMjlETuCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jiYzsvUd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iSC7ABjk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jiYzsvUd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iSC7ABjk" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8Dg0X692883 for ; Thu, 18 Jun 2026 09:22:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ymu1pZtY6Qzkufo8znnNgsaolHtKmq4ib+tAPwdv2dQ=; b=jiYzsvUdYkkGcfQT uYJjPMIvJAKYooqcW/rpZxHfMuZ24DwMjSddeNzkdU4lKdlHQDzy7XpA1KymqsMa tgz1knuW8renpZP3odni5MrwULG0IiYoGOLEFTlJO5hYN20sqxewW7qTZfjX94Ec Aj6Iz3QDRO4NOXOgpkIgbrfSS0dRGXfU994nhjnadkCg9vp4iU2fvZoAL8w1pAeK 1XgkYuo/4OKhATZF5jF1RAao6H5Q49rLa9G+tioXeJNjbyGYrkhO1jBXKkb7H6ss 7KVyMjhyb7QNX7IPV7O17BTZ9fTsKfSxMNN2dDavgOESNTGjMNrUGr7XaadxhLcg rUvCOQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eux2cbv7g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 09:22:24 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-842688fa7b8so1692335b3a.0 for ; Thu, 18 Jun 2026 02:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781774543; x=1782379343; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=ymu1pZtY6Qzkufo8znnNgsaolHtKmq4ib+tAPwdv2dQ=; b=iSC7ABjksvi+edjdzeRtCzgaOgkYk/I+QHATriWFQJ47ziEYWKisKPD+cciCjDMlx8 XSvhImInl/irlBIJJu2qkOgwdlci8SkUrPVbSBYy0DvKlcmRBn1iiT6NPPsNPz9+1aK1 Kyo2lVabj4MmA8/p/m8H1dUWVJt8NMIYwA4oRrIyJI62b2LuB24Bc5zg3DqwyjJ2aoip YjW9f43KcTblfIw6FCEhcj49Gqqj1tUmrTopD4tZTL2YscwuS63rESL1j8AAUEcxEFX1 SvjD7v7CjxDV7FejL67OYBOt1EGNaVS+dwy51KY64A15iX7jQVWnTdBcGY8r/CcuGQYz a2hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781774543; x=1782379343; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ymu1pZtY6Qzkufo8znnNgsaolHtKmq4ib+tAPwdv2dQ=; b=R2vb9zz31sHMTNXkLij3O8+qFFllb0//q6HnVRCyLW9CiNRIpQUfFrj98z3Q0GEgoy QtXWi72eOk49sHnSrmIUNl3zNejvwIW6ko7XXnnaJf4P6sXQa6wsyVON79u7w2Gg5aF+ 5Uv9Yv9Z5EoSgFY636szRttH18ePgClt2dmEh9eJQ4ocYBJp7vdJaSYab16l+GxasRVI AePtH6roG8tKr+RDMroX11Yn0AqIreiJcLPJClOVuvYdErWq+S9k+1kPqCFEp7ewnyjL Te5HfNcXKkE3jmOw5WcSBNHfmfP+Ft20M8cnNBY5Fmo0Jw+IaixEKQNCRsu+jcQBLYRE /I8Q== X-Forwarded-Encrypted: i=1; AFNElJ959UFKqq1fOAhx5qu/vi0pP5e7bR8fbH28K23iurpygyowhM1VojgOMTUFA5LHNL6GKB4TgMV+IQX5nkw=@vger.kernel.org X-Gm-Message-State: AOJu0YzMH1ftG6Mh2ABJOHuRXXV9wmvvWcGgze9H0Yft5b/QT7VkLWTu BMH6R4xA1gicap95FA+05MZtn2wPIwa8z8MD22PteDU7kXcEkMtVYIexSHGpB+OkLMlla7wxKqk gmXC1Qf7a6L+V8B1995oxpux8TE5rHTOYwAsWZnNSgrRNKJZkQ0ZeKQfireJ40nht8P6EwY+EgH 0= X-Gm-Gg: Acq92OF5Pf9jfZYpqfj8LnxqDJfjkHah53DT3M2GF9q9GjtGBoTxJT8POZzc580uHBf +xuJV4gsV1c/lDAg7K2KcvnI4j5hAViCT4m8u4PBQeioHX2pJByLn0XNhkPxWw/EKgd84XLXOwd EutdxxUY/io6s8flN7wAX5Yinrnm1NRFXkC7CXyOPIE3dfi26GrnVA0QoiuRi++1DyJ785iiAwS xzTWxqs3K/WKQv5Uge6PWt7RHENuwcNHfRxIM/YlBGkoOOQzYQJ01lROt9BRmpYULbwZc5g+tgP 0XxMUB0fdiOfBK8EMiq+duEOKvXK92+x+WGLaxCuRcclEZvfV43D/HqmvkrhPF+wyBpR2G2FWP9 y1kwLy2j7Fw8rvdTnH39+vi5+++hu2QPSd0XjNGmCU/qpUd8gvF/og00aQ30= X-Received: by 2002:a05:6a00:812:b0:82f:684a:84ea with SMTP id d2e1a72fcca58-845391e1084mr2643989b3a.13.1781774543337; Thu, 18 Jun 2026 02:22:23 -0700 (PDT) X-Received: by 2002:a05:6a00:812:b0:82f:684a:84ea with SMTP id d2e1a72fcca58-845391e1084mr2643961b3a.13.1781774542841; Thu, 18 Jun 2026 02:22:22 -0700 (PDT) Received: from [10.137.71.130] ([106.197.93.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434accbec5sm18638584b3a.16.2026.06.18.02.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 02:22:22 -0700 (PDT) Message-ID: Date: Thu, 18 Jun 2026 14:52:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next 3/5] wifi: ath12k: add HAL ops for monitor TLV header decode and alignment From: Vasanthakumar Thiagarajan To: Miaoqing Pan , jjohnson@kernel.org Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260509025819.1641630-1-miaoqing.pan@oss.qualcomm.com> <20260509025819.1641630-4-miaoqing.pan@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA4NiBTYWx0ZWRfX5APCUfQvU7Di cfrJQwmQtT6FcHCT8A3pjEDlU7XX+c5RHRB7BbLYk/w1AeAy5Sls5jnPvSXmhZXqNTEK/y+5dUt Q8OMF4XOWB/2WRMtMCJJzH04zMVyzm+5opTLI80fIQoOZpfKKuwHgZlM66hgEuw0TcM10dobWqI UexW1jKdK4mChmrb7HGPdc3Rj7bwBEE8XxAcR58SsQ7wPFZvWQvzT9VwTO3A5D3JKS5vYIHkw6s XVKhnnFKRgqONuZNpXWwYzSb1wV+/wtxNoMVX+Zuj6Prqg5Ih1yXrCvMSTLfY26or8LbYLQTHlT gp1D229C8S4FnQQkn/XdM43Eq/swMdOkeHV5oYprH0YUCLFao51mqlFRRLsavSq5dj1kadYMYFQ TOxdjKFMz8AF02yoRHMLXQUPsuOI53Mqtr8fbzPJhW/QzfyLqqYjdaKo0aO7eoAoUVFdCobOYgm kKScX0yv5URTK9PHaYA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA4NiBTYWx0ZWRfX+lpPXK1PfMfM 2POwcegY1OeThFUrtTB6Ky3Aa0V5vnBz9t7WMYJb9BpqUAZ6Da5tNq+dDLykGuMqdTVP5DxGd9F d8vpcpWu0hMA7Q7gWdUTnqpewAFrjEQ= X-Proofpoint-GUID: po-XupKVseP7L0NxqeDWrsoi_tHKPydi X-Proofpoint-ORIG-GUID: po-XupKVseP7L0NxqeDWrsoi_tHKPydi X-Authority-Analysis: v=2.4 cv=WN1PmHsR c=1 sm=1 tr=0 ts=6a33b8d0 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=wlpA7Av3g41Jdys7FXR3eg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=REP3-BY0cBNZE2ghv4IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180086 On 6/18/2026 2:43 PM, Vasanthakumar Thiagarajan wrote: > > > On 5/9/2026 8:28 AM, Miaoqing Pan wrote: >> Wi-Fi 7 monitor RX status TLV parsing needs to decode TLV headers and >> advance the pointer with the correct header alignment. Different targets >> use different TLV header layouts (32-bit vs 64-bit), but the HAL ops for >> dp_mon RX status header decode and header alignment were not populated >> for all wifi7 targets. >> >> Add dp_mon RX status TLV header decode callbacks and TLV header alignment >> helpers to the wifi7 HAL ops for QCC2072, QCN9274 and WCN7850. Export >> helpers to query the required TLV header alignment for 32-bit and 64-bit >> TLV headers so the caller can align the TLV walk correctly across targets. >> >> Tested-on: QCC2072 hw1.0 PCI WLAN.COL.1.0.c2-00068-QCACOLSWPL_V1_TO_SILICONZ-1 >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3 >> >> Signed-off-by: Miaoqing Pan >> --- >>   drivers/net/wireless/ath/ath12k/hal.c               | 12 ++++++++++++ >>   drivers/net/wireless/ath/ath12k/hal.h               |  4 ++++ >>   drivers/net/wireless/ath/ath12k/wifi7/hal_qcc2072.c |  2 ++ >>   drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c |  2 ++ >>   drivers/net/wireless/ath/ath12k/wifi7/hal_wcn7850.c |  2 ++ >>   5 files changed, 22 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/ath12k/hal.c b/drivers/net/wireless/ath/ath12k/hal.c >> index d940f83cd92f..c0c3d2f047ef 100644 >> --- a/drivers/net/wireless/ath/ath12k/hal.c >> +++ b/drivers/net/wireless/ath/ath12k/hal.c >> @@ -875,3 +875,15 @@ void *ath12k_hal_decode_tlv32_hdr(void *tlv, u16 *tag, u16 *len, >> u16 *usrid) >>       return tlv32->value; >>   } >>   EXPORT_SYMBOL(ath12k_hal_decode_tlv32_hdr); >> + >> +u32 ath12k_hal_get_tlv64_hdr_align(void) >> +{ >> +    return HAL_TLV_64_ALIGN; >> +} >> +EXPORT_SYMBOL(ath12k_hal_get_tlv64_hdr_align); >> + >> +u32 ath12k_hal_get_tlv32_hdr_align(void) >> +{ >> +    return HAL_TLV_ALIGN; >> +} >> +EXPORT_SYMBOL(ath12k_hal_get_tlv32_hdr_align); >> diff --git a/drivers/net/wireless/ath/ath12k/hal.h b/drivers/net/wireless/ath/ath12k/hal.h >> index 3158c1881c76..312993d3d5d4 100644 >> --- a/drivers/net/wireless/ath/ath12k/hal.h >> +++ b/drivers/net/wireless/ath/ath12k/hal.h >> @@ -1439,6 +1439,8 @@ struct hal_ops { >>                        u8 *rbm, u32 *msdu_cnt); >>       void *(*reo_cmd_enc_tlv_hdr)(void *tlv, u64 tag, u64 len); >>       u16 (*reo_status_dec_tlv_hdr)(void *tlv, void **desc); >> +    void *(*mon_rx_status_dec_tlv_hdr)(void *tlv, u16 *tag, u16 *len, u16 *usrid); >> +    u32 (*get_tlv_hdr_align)(void); >>   }; >>   #define HAL_TLV_HDR_TAG        GENMASK(9, 1) >> @@ -1553,4 +1555,6 @@ void *ath12k_hal_encode_tlv64_hdr(void *tlv, u64 tag, u64 len); >>   void *ath12k_hal_encode_tlv32_hdr(void *tlv, u64 tag, u64 len); >>   void *ath12k_hal_decode_tlv64_hdr(void *tlv, u16 *tag, u16 *len, u16 *usrid); >>   void *ath12k_hal_decode_tlv32_hdr(void *tlv, u16 *tag, u16 *len, u16 *usrid); >> +u32 ath12k_hal_get_tlv64_hdr_align(void); >> +u32 ath12k_hal_get_tlv32_hdr_align(void); >>   #endif >> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcc2072.c >> b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcc2072.c >> index c0583c3a2191..80ffadc47d48 100644 >> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcc2072.c >> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcc2072.c >> @@ -490,6 +490,8 @@ const struct hal_ops hal_qcc2072_ops = { >>       .rx_reo_ent_buf_paddr_get = ath12k_wifi7_hal_rx_reo_ent_buf_paddr_get, >>       .reo_cmd_enc_tlv_hdr = ath12k_hal_encode_tlv32_hdr, >>       .reo_status_dec_tlv_hdr = ath12k_hal_reo_status_dec_tlv_hdr_qcc2072, >> +    .mon_rx_status_dec_tlv_hdr = ath12k_hal_decode_tlv32_hdr, >> +    .get_tlv_hdr_align = ath12k_hal_get_tlv32_hdr_align, > > ops get_tlv_hdr_align() seems unused, may be patch 4/5 is supposed to > used this ops instead of removing the alignment? My bad, somehow overlooked it, it is indeed used in the patch 4/5.