mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: ardb@kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-efi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
	kernel@gpiccoli.net, matt@codeblueprint.co.uk,
	mjg59@srcf.ucam.org
Subject: Re: [PATCH V2] efi: efibc: Guard against allocation failure
Date: Sun, 11 Sep 2022 11:36:00 -0300	[thread overview]
Message-ID: <e8ce8fb4-baac-b3a5-5d6d-418e20c8d2d9@igalia.com> (raw)
In-Reply-To: <04d65bd7-a6b2-bb14-fd69-632542ae9e86@wanadoo.fr>

On 10/09/2022 01:56, Christophe JAILLET wrote:
> [...]
>>   	wdata = kmalloc(MAX_DATA_LEN * sizeof(efi_char16_t), GFP_KERNEL);
> Hi,
> 
> even if mostly useless in this case, kmalloc_array()?
> 
> Or certainly maybe even better, kstrndup()?
> 
> CJ
> 

Thanks! It's up to Ard, I could rework with this change if makes sense.
Cheers,


Guilherme

  reply	other threads:[~2022-09-11 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 19:42 Guilherme G. Piccoli
2022-09-10  4:56 ` Christophe JAILLET
2022-09-11 14:36   ` Guilherme G. Piccoli [this message]
2022-09-20 16:44     ` Ard Biesheuvel
2022-09-20 17:47       ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8ce8fb4-baac-b3a5-5d6d-418e20c8d2d9@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=ardb@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®