From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Alexander Wilhelm <alexander.wilhelm@westermo.com>,
Jeff Johnson <jjohnson@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 4/4] wifi: ath12k: enforce CPU-endian format for all QMI
Date: Thu, 18 Sep 2025 09:31:18 -0700 [thread overview]
Message-ID: <e8d283aa-fb73-45d6-a89a-54ff31f205c8@oss.qualcomm.com> (raw)
In-Reply-To: <20250918085406.2049559-5-alexander.wilhelm@westermo.com>
On 9/18/2025 1:53 AM, Alexander Wilhelm wrote:
> Due to internal endianness handling within the QMI subsystem, all QMI
> requests and responses must now be provided in CPU byte order. Replace all
> QMI-related data types with CPU-endian types and add the necessary
> conversions to ensure correct interpretation across architectures.
I think you can break this out into a separate patch, but reword in a manner
that doesn't indicate any dependency upon your series (it can be a predecessor)
You can do that by noting:
1) currently (before your series) the QMI interface only works on LE systems
because of how it encodes and decodes the data
2) however almost all QMI data structures did NOT use endianess-specific types
for the data structures
3) the ath12k structs being modified are exceptions
4) the QMI interfaces are being modified to support BE, and that modification
requires the QMI data structures to actually be in CPU order
5) So change the two ath12k QMI struct which currently use endianess-specific
types
6) This change will work correctly with existing kernels (which only support
LE) and will also work on future kernels where BE support is added.
Then I can take this patch separately from the QMI changes.
/jeff
next prev parent reply other threads:[~2025-09-18 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 8:53 [PATCH v3 0/4] wifi: ath12k: Fix endianness handling in QMI Alexander Wilhelm
2025-09-18 8:53 ` [PATCH v3 1/4] soc: qcom: introduce new QMI encode/decode macros Alexander Wilhelm
2025-09-18 8:53 ` [PATCH v3 2/4] soc: qcom: fix QMI encoding/decoding for basic elements Alexander Wilhelm
2025-09-18 8:53 ` [PATCH v3 3/4] soc: qcom: preserve CPU endianness for QMI_DATA_LEN Alexander Wilhelm
2025-09-18 8:53 ` [PATCH v3 4/4] wifi: ath12k: enforce CPU-endian format for all QMI Alexander Wilhelm
2025-09-18 16:31 ` Jeff Johnson [this message]
2025-09-19 7:07 ` Alexander Wilhelm
2025-09-19 18:23 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8d283aa-fb73-45d6-a89a-54ff31f205c8@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=alexander.wilhelm@westermo.com \
--cc=andersson@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®