Re: [PATCH V1] accel/amdxdna: Fully initialize map structure before registering notifier

[Max Zhen <max.zhen@amd.com>]

On 9/11/2026 Fri 09:39, Lizhi Hou wrote:
> The map structure is currently only partially initialized when the
> notifier is registered. Although holding mmap_write_lock() prevents
> the notifier callback from running before the remaining initialization
> is complete, the ordering can be confusing during code review.
> 
> Fully initialize the map structure before registering the notifier so
> that the structure is completely constructed before it is published.
> 
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Max Zhen <max.zhen@amd.com>
> ---
>   drivers/accel/amdxdna/amdxdna_gem.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c
> index 5a1a2ee261b7..e861db6f9369 100644
> --- a/drivers/accel/amdxdna/amdxdna_gem.c
> +++ b/drivers/accel/amdxdna/amdxdna_gem.c
> @@ -415,6 +415,15 @@ static int amdxdna_hmm_register(struct amdxdna_gem_obj *abo,
>   		goto free_map;
>   	}
>   
> +	mapp->range.notifier = &mapp->notifier;
> +	mapp->range.start = vma->vm_start;
> +	mapp->range.end = vma->vm_end;
> +	mapp->range.default_flags = HMM_PFN_REQ_FAULT;
> +	mapp->abo = abo;
> +	kref_init(&mapp->refcnt);
> +
> +	INIT_WORK(&mapp->hmm_unreg_work, amdxdna_hmm_unreg_work);
> +
>   	ret = mmu_interval_notifier_insert_locked(&mapp->notifier,
>   						  current->mm,
>   						  addr,
> @@ -425,15 +434,6 @@ static int amdxdna_hmm_register(struct amdxdna_gem_obj *abo,
>   		goto free_pfns;
>   	}
>   
> -	mapp->range.notifier = &mapp->notifier;
> -	mapp->range.start = vma->vm_start;
> -	mapp->range.end = vma->vm_end;
> -	mapp->range.default_flags = HMM_PFN_REQ_FAULT;
> -	mapp->abo = abo;
> -	kref_init(&mapp->refcnt);
> -
> -	INIT_WORK(&mapp->hmm_unreg_work, amdxdna_hmm_unreg_work);
> -
>   	down_write(&xdna->notifier_lock);
>   	if (list_empty(&abo->mem.umap_list))
>   		abo->mem.uva = addr;