From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FC6C43334 for ; Tue, 21 Jun 2022 04:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345799AbiFUEJn (ORCPT ); Tue, 21 Jun 2022 00:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbiFUEIW (ORCPT ); Tue, 21 Jun 2022 00:08:22 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9889519019; Mon, 20 Jun 2022 21:08:19 -0700 (PDT) X-UUID: 0220861514dc4317b4c3844f9614faf5-20220621 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:57d9eafa-a58b-4749-a2fb-b984fb888fe2,OB:10,L OB:10,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,A CTION:release,TS:45 X-CID-INFO: VERSION:1.1.6,REQID:57d9eafa-a58b-4749-a2fb-b984fb888fe2,OB:10,LOB :10,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-META: VersionHash:b14ad71,CLOUDID:3df3992d-1756-4fa3-be7f-474a6e4be921,C OID:de8a5d5f857e,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 0220861514dc4317b4c3844f9614faf5-20220621 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1381626784; Tue, 21 Jun 2022 12:08:13 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 21 Jun 2022 12:08:11 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 21 Jun 2022 12:08:11 +0800 Message-ID: Subject: Re: [PATCH v12 11/14] drm/mediatek: dpi: Add tvd_clk enable/disable flow From: CK Hu To: Rex-BC Chen , , , , , , , CC: , , , , , , , , , , Date: Tue, 21 Jun 2022 12:08:11 +0800 In-Reply-To: <4a873de158868368818c00fbfee1a03f620ad8c9.camel@mediatek.com> References: <20220620121028.29234-1-rex-bc.chen@mediatek.com> <20220620121028.29234-12-rex-bc.chen@mediatek.com> <218de671054a2c02d47a0bb4a31a0b07d24d7eee.camel@mediatek.com> <7bffe5226a80474f150ef67e36d2b75ea8e8a9d8.camel@mediatek.com> <6af179e2995ce2f4f2e7c72f10516afb0c1604a3.camel@mediatek.com> <4a873de158868368818c00fbfee1a03f620ad8c9.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rex: On Tue, 2022-06-21 at 11:50 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-21 at 11:45 +0800, CK Hu wrote: > > On Tue, 2022-06-21 at 11:11 +0800, Rex-BC Chen wrote: > > > On Tue, 2022-06-21 at 10:55 +0800, CK Hu wrote: > > > > Hi, Bo-Chen: > > > > > > > > On Mon, 2022-06-20 at 20:10 +0800, Bo-Chen Chen wrote: > > > > > We should enable/disable tvd_clk when power_on/power_off, so > > > > > add > > > > > this > > > > > patch to do this. > > > > > > > > Without this patch, what would happen? > > > > It seems this patch is redundant for these SoCs: > > > > > > > > static const struct of_device_id mtk_dpi_of_ids[] = { > > > > { .compatible = "mediatek,mt2701-dpi", > > > > .data = &mt2701_conf, > > > > }, > > > > { .compatible = "mediatek,mt8173-dpi", > > > > .data = &mt8173_conf, > > > > }, > > > > { .compatible = "mediatek,mt8183-dpi", > > > > .data = &mt8183_conf, > > > > }, > > > > { .compatible = "mediatek,mt8192-dpi", > > > > .data = &mt8192_conf, > > > > }, > > > > { }, > > > > }; > > > > > > > > Regards, > > > > CK > > > > > > > > > > Hello CK, > > > > > > IMO, this is a bug fix patch. From the usage of clock, if we want > > > to > > > use it, we should enable it . Therefore, I think we should add > > > this > > > and > > > I will add a fix tag for this patch. > > > > I think mt8173 chromebook use this driver for HDMI output. So > > mt8173 > > chromebook HDMI could not work normally? > > > > Regards, > > CK > > > > Hmm.. > I am not sure about this. But without this patch, dpi is also working > in mt8183/mt8192. It may be related to the ccf driver. But anyway, I > think we should do this whether ccf driver helps us to enable this > clock. OK. So, could you help to fix the bug in ccf? If HDMI is disabled but ccf still turn on this clock, the power would be wasted. Regards, CK > > BRs, > Bo-Chen > > > > > > > BRs, > > > Bo-Chen > > > > > > > > > > > > > > Signed-off-by: Bo-Chen Chen > > > > > --- > > > > > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 ++++++++++- > > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > > > > > b/drivers/gpu/drm/mediatek/mtk_dpi.c > > > > > index 2717b1741b7a..f83ecb154457 100644 > > > > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > > > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > > > > @@ -455,6 +455,7 @@ static void mtk_dpi_power_off(struct > > > > > mtk_dpi > > > > > *dpi) > > > > > mtk_dpi_disable(dpi); > > > > > clk_disable_unprepare(dpi->pixel_clk); > > > > > clk_disable_unprepare(dpi->engine_clk); > > > > > + clk_disable_unprepare(dpi->tvd_clk); > > > > > } > > > > > > > > > > static int mtk_dpi_power_on(struct mtk_dpi *dpi) > > > > > @@ -464,10 +465,16 @@ static int mtk_dpi_power_on(struct > > > > > mtk_dpi > > > > > *dpi) > > > > > if (++dpi->refcount != 1) > > > > > return 0; > > > > > > > > > > + ret = clk_prepare_enable(dpi->tvd_clk); > > > > > + if (ret) { > > > > > + dev_err(dpi->dev, "Failed to enable tvd pll: > > > > > %d\n", > > > > > ret); > > > > > + goto err_refcount; > > > > > + } > > > > > + > > > > > ret = clk_prepare_enable(dpi->engine_clk); > > > > > if (ret) { > > > > > dev_err(dpi->dev, "Failed to enable engine > > > > > clock: > > > > > %d\n", ret); > > > > > - goto err_refcount; > > > > > + goto err_engine; > > > > > } > > > > > > > > > > ret = clk_prepare_enable(dpi->pixel_clk); > > > > > @@ -484,6 +491,8 @@ static int mtk_dpi_power_on(struct > > > > > mtk_dpi > > > > > *dpi) > > > > > > > > > > err_pixel: > > > > > clk_disable_unprepare(dpi->engine_clk); > > > > > +err_engine: > > > > > + clk_disable_unprepare(dpi->tvd_clk); > > > > > err_refcount: > > > > > dpi->refcount--; > > > > > return ret; > > > > > > > > > > > > > > > > > > > >