From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D42FC433E6 for ; Mon, 29 Mar 2021 02:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C1DC61922 for ; Mon, 29 Mar 2021 02:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbhC2CAw (ORCPT ); Sun, 28 Mar 2021 22:00:52 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14175 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231380AbhC2CAk (ORCPT ); Sun, 28 Mar 2021 22:00:40 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F7whV1X4bznWgZ; Mon, 29 Mar 2021 09:58:02 +0800 (CST) Received: from [10.174.177.134] (10.174.177.134) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 29 Mar 2021 10:00:29 +0800 Subject: Re: [PATCH] powerpc: Fix HAVE_HARDLOCKUP_DETECTOR_ARCH build configuration To: Christophe Leroy , Michael Ellerman , Benjamin Herrenschmidt , "Paul Mackerras" CC: Don Zickus , , "Nicholas Piggin" , Hulk Robot , Andrew Morton , References: <20210327094900.938555-1-chenhuang5@huawei.com> From: Chen Huang Message-ID: Date: Mon, 29 Mar 2021 10:00:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.134] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/3/28 19:06, Christophe Leroy 写道: > > > Le 27/03/2021 à 10:49, Chen Huang a écrit : >> When compiling the powerpc with the SMP disabled, it shows the issue: >> >> arch/powerpc/kernel/watchdog.c: In function ‘watchdog_smp_panic’: >> arch/powerpc/kernel/watchdog.c:177:4: error: implicit declaration of function ‘smp_send_nmi_ipi’; did you mean ‘smp_send_stop’? [-Werror=implicit-function-declaration] >>    177 |    smp_send_nmi_ipi(c, wd_lockup_ipi, 1000000); >>        |    ^~~~~~~~~~~~~~~~ >>        |    smp_send_stop >> cc1: all warnings being treated as errors >> make[2]: *** [scripts/Makefile.build:273: arch/powerpc/kernel/watchdog.o] Error 1 >> make[1]: *** [scripts/Makefile.build:534: arch/powerpc/kernel] Error 2 >> make: *** [Makefile:1980: arch/powerpc] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> We found that powerpc used ipi to implement hardlockup watchdog, so the >> HAVE_HARDLOCKUP_DETECTOR_ARCH should depend on the SMP. >> >> Fixes: 2104180a5369 ("powerpc/64s: implement arch-specific hardlockup watchdog") >> Reported-by: Hulk Robot >> Signed-off-by: Chen Huang >> --- >>   arch/powerpc/Kconfig | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >> index 764df010baee..2d4f37b117ce 100644 >> --- a/arch/powerpc/Kconfig >> +++ b/arch/powerpc/Kconfig >> @@ -225,7 +225,7 @@ config PPC >>       select HAVE_LIVEPATCH            if HAVE_DYNAMIC_FTRACE_WITH_REGS >>       select HAVE_MOD_ARCH_SPECIFIC >>       select HAVE_NMI                if PERF_EVENTS || (PPC64 && PPC_BOOK3S) >> -    select HAVE_HARDLOCKUP_DETECTOR_ARCH    if (PPC64 && PPC_BOOK3S) >> +    select HAVE_HARDLOCKUP_DETECTOR_ARCH    if PPC64 && PPC_BOOK3S && SMP > > While modifying this line, you should restore the alphabetic order by moving it up. > > You can use PPC_BOOK3S_64 instead of PPC64 && PPC_BOOK3S > I will modify it. Thanks! >>       select HAVE_OPTPROBES            if PPC64 >>       select HAVE_PERF_EVENTS >>       select HAVE_PERF_EVENTS_NMI        if PPC64 >> > .