From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751630AbdJRTbe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Oct 2017 15:31:34 -0400
Received: from mail-qt0-f193.google.com ([209.85.216.193]:49974 "EHLO
        mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751346AbdJRTbc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Oct 2017 15:31:32 -0400
X-Google-Smtp-Source: ABhQp+QIdLken7Kgdz1dzLHKF7vNtg1Km+nQu6VhP8Any+81fJT7IyE46qZEZKt6t07xeMNBZMHjvg==
Subject: Re: [PATCH 0/1] net: ethtool: add SmartNIC reset support
To: Andrew Lunn <andrew@lunn.ch>
References: <1508342496-5047-1-git-send-email-scott.branden@broadcom.com>
 <20171018162823.GB15371@lunn.ch>
 <b9f6864a-e746-bb0d-ec8f-b85924276266@broadcom.com>
 <20171018191639.GI15371@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
        "Allan W. Nielsen" <allan.nielsen@microsemi.com>,
        Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        linux-kernel@vger.kernel.org, Steve Lin <steven.lin1@broadcom.com>
From: Scott Branden <scott.branden@broadcom.com>
Message-ID: <e8f5b581-2613-0dda-d9cc-e826a14ee394@broadcom.com>
Date: Wed, 18 Oct 2017 12:31:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20171018191639.GI15371@lunn.ch>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,


On 17-10-18 12:16 PM, Andrew Lunn wrote:
>> Yes, there is also a management processor.
> O.K.
>
> Maybe it would be nice to add some more text to the commit message to
> make this clear. Define what an application processor is, and how it
> differs from a management processor. But othersize:
OK -will add more description to differentiate management processor vs. 
application processor(s).
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> I assume you have another kernel patch to actually make use of this?
> It is normal to post the user of a new API in the same series as the
> API.
I actually wanted to get agreement that the bit define could be added to 
ethtool before implementing it in driver.
If this direction approved we'll implement in driver and submit with 
this patch series.
>
>      Andrew
Thanks,
  Scott