From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4623FC433EF for ; Tue, 2 Nov 2021 23:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29DCD610C8 for ; Tue, 2 Nov 2021 23:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231480AbhKBXTK (ORCPT ); Tue, 2 Nov 2021 19:19:10 -0400 Received: from foss.arm.com ([217.140.110.172]:47126 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbhKBXTI (ORCPT ); Tue, 2 Nov 2021 19:19:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1136511B3; Tue, 2 Nov 2021 16:16:33 -0700 (PDT) Received: from [10.57.47.15] (unknown [10.57.47.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37F4D3F719; Tue, 2 Nov 2021 16:16:31 -0700 (PDT) Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Arnd Bergmann Cc: Arnd Bergmann , Will Deacon , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> From: Suzuki K Poulose Message-ID: Date: Tue, 2 Nov 2021 23:16:30 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd On 29/10/2021 19:06, Catalin Marinas wrote: > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: >> On 29/10/2021 12:30, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> It's now used in a coresight driver that can be a loadable module: >>> >>> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! >>> >>> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") >> >> Reviewed-by: Suzuki K Poulose >> Tested-by: Suzuki K Poulose >> >> Will, Catalin, Mathieu, >> >> Do you have a preference on how this fix can be pulled in ? This may >> be safe to go via coresight tree if it is not too late. Otherwise, >> it could go via the arm64 tree. > > I think Will already closed/tagged the arm64 tree for the upcoming > merging window, though he could take it as a fix afterwards. > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > go through the coresight tree. > >>> Signed-off-by: Arnd Bergmann >>> --- >>> Not sure if we actually want this to be exported, this is my local >>> workaround for the randconfig build bot. >>> --- >>> arch/arm64/kernel/cpufeature.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >>> index ecbdff795f5e..beccbcfa7391 100644 >>> --- a/arch/arm64/kernel/cpufeature.c >>> +++ b/arch/arm64/kernel/cpufeature.c >>> @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) >>> return false; >>> } >>> +EXPORT_SYMBOL(this_cpu_has_cap); > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > specialised than cpus_have_const_cap(). > > With that: > > Acked-by: Catalin Marinas > Do you plan to send an updated patch with above ? Suzuki