From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BFF51E22E9 for ; Thu, 9 Apr 2026 08:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722719; cv=none; b=rfY49YmFLZ2ElOQWEvOmMeJz61/YCfDye5epVF3r42nYiJwIjxDY9Rm1xx6T5PYSldYW+kitgZTFgsfgTpy8Kup5sWFh3J9eDhB41whlU00SuFjk6sQ99erlktj8rUUED+amdHDTC5seHKasPf+CZN2soC3VhBfj8K0SObrE56Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722719; c=relaxed/simple; bh=m5tFcopWBSKNdB53LAhal06l0yyzaqheMmMZSLpC6Hs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L125e/dBl3Cv5Ry12zl57s8oRJiNjY0iWhv2vccTawQE0zGKE1p0ZxssvHY0E1Rw9tGbOfYSWQQGR42cUTXJ6NaZD6CVUl1HYJp6ocqJlB5DQrx+6a91l6Rzha4zoHz0D5TbjLUm268RZyL79sb3fWJoP4YMex5D/NBIS31O3O8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SOQENC9Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VdK8YVHK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SOQENC9Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VdK8YVHK" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6392h2Zt3326005 for ; Thu, 9 Apr 2026 08:18:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8z8l8qSYfoO88CPg9LA+QREeSlAoVd+weN+GhlGYusQ=; b=SOQENC9Q2W7xoIA2 7Zl+/EymyBhWDyDzQO4xyLCSdxUDHMw1OMMw7GLZJr/hJ1S17DoPcFTamBiljcN8 TptuqnNopzINV7hd3cJGLuhOwxs44ZLOXxF17God9cmXbiDdz93koLxWi0ak4nLV YznZfd9FHhK4UM4N1AM/PltB2m10nVZFTFGpqtdT9wmOqcWMf5tRivbpeQvgkxIU vUSNCxF3q8NZu0D+ealf0sZ8qdKete2l2j2L5KeM2AnMKDCZvuQdj0l3FjGdTqBR umo+Byw+QHr8Pwu1OvTdyNQkbDHuv24S4ikPOaWFWg7tRgGpWWE5KPidBySr8okO xM5v0A== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddw9mt89h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Apr 2026 08:18:37 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cfe29579d5so8443685a.3 for ; Thu, 09 Apr 2026 01:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775722717; x=1776327517; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8z8l8qSYfoO88CPg9LA+QREeSlAoVd+weN+GhlGYusQ=; b=VdK8YVHKezToXzakrYf8LiFn056ktoQ0q/FehYR88VNQuz9v48/QVkKeDii6oPK8hW 9jqpry94kb5mxHtsSRBOtF8r9MsDeIrJQQzmFGJNjsLGLMF7HFFwfhqMFGrE3AMvZ7gu XZ7eXs96N0SEIy/wVl2YvPMmmmZhW08MdfzTWsSketAby19siNFQ/9AkxT2bjGI2Dlyz xoF9ijXFXcEfYYTFvQmZnwvuGHx4aMK4mpWqMadObeVdxs67e7qlzD/q9M2XyOMP8QUZ qO3wwYQnxwWLgRnxHoQEEbNn1CKO2QBmaKHxetyDn29cF7LpUdNgDRFrP7Xtma47TBKg C2OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775722717; x=1776327517; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8z8l8qSYfoO88CPg9LA+QREeSlAoVd+weN+GhlGYusQ=; b=Zx72Sh8PUD55pyWmsmI5edtb2h1MvkLjJ5456zqdTtBZBk2E7HwTGro7RISXMHB8tS LDyk+9b87VJjlZPtGAGKYK3aciq37TKsiyYbJsjYNsq0YN6xbSjzY1gVat/AR1Ynqp4W a8qD1V8M8iuDBcwLYCX3VfxHqWMjiDWjfgnGNi4PLIhFOq5QRuKiW8PRxJd3MtK9s4nJ Igpahhf50owUyXnUIvLqVE7auiDlsK7oBkRV4o7jMNB1kYUIbeGt2Y+wmc4LhNDtOeny i/FdT+a2H6AcU4Ao0hSN5rzMaTt+eq5zyDWeSrMCsGapWicx2I2hy7pJtOzfcFbAgFbg ysrw== X-Forwarded-Encrypted: i=1; AJvYcCUU6gPPCoIco2p2shd2TjTkK/zMiBcKsV6pQd5lboAaXVopCOphpjR28iy3LeVLGd7Qdaik4raqVGnPsj8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3q8uRZ4A8y357y28dVicCFn3UMitrcf9/1CH4FpjKsfXEN3K/ mrBp+A/UfyrtpjsET9PxoR5bUSie4yZg6IzoYlnSGK7ZAU6dSJt0Phsbc2x+TRCI9gD3oA3wG+W M64b+V6OoGoW2IUa/z6RsOFv9mBrCSQebiiLG7+xM4wn8QsCtXSF7TvKfd+EqiOca3Es= X-Gm-Gg: AeBDieuvaPL33GcPEIB77awxYBhi+sZDEJQ95e1IS0NaFu9+J0wZ7Il9nz/Ri8Inyfh UGEtKahT2heHSAOoEqKmKEZ755vFEOJ9mhxTIueEefOPSIiW2ApESHY5TxjU7HT/tT5oH0jsD1D tJtN5R+8NCWmuBdCo7KOKGZzHRk2ehLMK81x5XduFa3cMTrCrIefnJY9t17Z7l65eJhPZy4NoAM hJFM10TIPsGfvbe5jEtgCgASYIkldqHZ4x2QJTBnOpqCYu1+neEe+SAn/H6UtrPJkF+Y3ChjC24 5qhiuxYj/m29qT+JAUNuXnJ3MAGzKF4/vzxGiHtlKFUpKHHDuTA6PjPVl/UGAc5mjWcluflQHPj pjT548lMm3z+SHj/ABfKP4nK63U7E0ILycqp/UzpjyO7pgMYzQuwBnx9m8pGOhdcCVmtEUq9uz3 Y29II= X-Received: by 2002:a05:620a:2984:b0:8d5:bb98:f3cf with SMTP id af79cd13be357-8dadf2de6a9mr740954185a.2.1775722716812; Thu, 09 Apr 2026 01:18:36 -0700 (PDT) X-Received: by 2002:a05:620a:2984:b0:8d5:bb98:f3cf with SMTP id af79cd13be357-8dadf2de6a9mr740952385a.2.1775722716307; Thu, 09 Apr 2026 01:18:36 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66e034b9284sm5893094a12.22.2026.04.09.01.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 01:18:35 -0700 (PDT) Message-ID: Date: Thu, 9 Apr 2026 10:18:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 2/2] net: ipa: Fix decoding EV_PER_EE for IPA v5.0+ To: Luca Weiss , Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260409-ipa-fixes-v1-0-a817c30678ac@fairphone.com> <20260409-ipa-fixes-v1-2-a817c30678ac@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260409-ipa-fixes-v1-2-a817c30678ac@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cfPiaHDM c=1 sm=1 tr=0 ts=69d760dd cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=c92rfblmAAAA:8 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=CILkcpHQ0ZtWuLMSmlYA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=GvGzcOZaWPEFPQC_NcjD:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: T7udk4IpZX5EGgHCt-irrAxA3d6lH3aN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA5MDA3MiBTYWx0ZWRfX24/yVc4oaL9x z4U1LIVFaegX/FKGmuQdsBp7DEg3+WaKEFVHJYfh1bTv2IUvNRyEIw93EZ9pWAQWyVLp7Iw08Rc 14ZTSIZcf0PvR7mcK2ja3rR2MR2LIDPCdhuVSvOfWsEFaJCwMqC+h6NSABbR/QXVG4hI81vpcV5 IL82C2bMJ1d07t9CAs6SdlJ9JTpdnF1WdrPTqI4HhjcXeKhcJTGl8rKz/OuSfhrfg7kpToKmvzz 73vpn1Ck6xKxg0ziZG5TpFWJSWnPiJqFcTXkiv/kytobfFNzUhumwoDk9hz6v8WjrLyAGyZnGQr lVrePI4JA2RHusOPLl8N7MiYJqq9rjG+UKXV91G7VqeUMOdK9z4xm0nNwQ4gObG0RE/QlJrH16q jUeXlMQIXUliyk9+B0A+aAp7OpCnZqCh7g2vbJ4lasnmD0w5YgCKgIBw9VfWeehnvAoLIbSVYga XVdsA5S/4b6nwchD7QQ== X-Proofpoint-GUID: T7udk4IpZX5EGgHCt-irrAxA3d6lH3aN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-09_02,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604090072 On 4/9/26 10:13 AM, Luca Weiss wrote: > Initially 'reg' and 'val' are assigned from HW_PARAM_2. > > But since IPA v5.0+ takes EV_PER_EE from HW_PARAM_4 (instead of > NUM_EV_PER_EE from HW_PARAM_2), we not only need to re-assign 'reg' but > also read the register value of that register into 'val' so that > reg_decode() works on the correct value. > > Fixes: f651334e1ef5 ("net: ipa: add HW_PARAM_4 GSI register") > Link: https://sashiko.dev/#/patchset/20260403-milos-ipa-v1-0-01e9e4e03d3e%40fairphone.com?part=2 > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad